Skip to content

Add --no-web-resources-cdn to all web integration tests #171013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Add --no-web-resources-cdn to all web integration tests #171013

merged 1 commit into from
Jun 23, 2025

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 23, 2025 •
edited
Loading

Let's avoid downloading canvaskit from the CDN in our integration tests.

Closes #110879

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 23, 2025
@mdebbar mdebbar mentioned this pull request Jun 23, 2025
Closed
biggs0125
biggs0125 approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@biggs0125 biggs0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can try this out and see if it fixes the tests. If it does I'll close out #170947

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 23, 2025
harryterkelsen
harryterkelsen approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into flutter:master with commit d733bea Jun 23, 2025
137 of 138 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025
@engine-flutter-autoroll
d733bea58 Add --no-web-resources-cdn to all web integration tests (f…
d2d6544 
…lutter/flutter#171013)
@mdebbar mdebbar deleted the no_cdn_integration_tests branch June 23, 2025 19:21
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 23, 2025
@engine-flutter-autoroll
Roll Flutter from 0ab008a17228 to d733bea58c1a (16 revisions) (#9478)
bf830ba 
flutter/flutter@0ab008a...d733bea

2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948)
2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@biggs0125
Copy link
Contributor

Confirmed the tests went green with this change. Thanks again!

Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 0ab008a17228 to d733bea58c1a (16 revisions) (flutte…
04cd745 
…r#9478)

flutter/flutter@0ab008a...d733bea

2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948)
2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@mdebbar @mboetger
Add --no-web-resources-cdn to all web integration tests (flutter#17…
0f1fe7f 
…1013)

Let's avoid downloading canvaskit from the CDN in our integration tests.

Closes flutter#110879
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@engine-flutter-autoroll @vashworth
Roll Flutter from 0ab008a17228 to d733bea58c1a (16 revisions) (flutte…
e3cac6f 
…r#9478)

flutter/flutter@0ab008a...d733bea

2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948)
2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
d733bea58 Add --no-web-resources-cdn to all web integration tests (f…
a7352a5 
…lutter/flutter#171013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
d733bea58 Add --no-web-resources-cdn to all web integration tests (f…
5ebd137 
…lutter/flutter#171013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
d733bea58 Add --no-web-resources-cdn to all web integration tests (f…
77fd246 
…lutter/flutter#171013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
d733bea58 Add --no-web-resources-cdn to all web integration tests (f…
f6efedd 
…lutter/flutter#171013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
d733bea58 Add --no-web-resources-cdn to all web integration tests (f…
6d0189c 
…lutter/flutter#171013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

@biggs0125 biggs0125 biggs0125 approved these changes

@eyebrowsoffire eyebrowsoffire Awaiting requested review from eyebrowsoffire

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter tools hot reload tests for web are failing with canvaskit
3 participants
@mdebbar @biggs0125 @harryterkelsen