Skip to content

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Jun 20, 2025

Description

This PR adds missing M3 tests for InputDecoration.floatingLabelAlignment.

Related Issue

Will help to complete #168981

Tests

Adds 8 tests (based on existing M2 tests).

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 20, 2025
@bleroux bleroux changed the title Add missing M3 tests fro InputDecoration.floatingLabelAlignment Add missing M3 tests for InputDecoration.floatingLabelAlignment Jun 20, 2025
@bleroux bleroux requested a review from QuncCccccc June 20, 2025 09:53
@bleroux bleroux force-pushed the migrate_InputDecoration.floatingLabelAlignment_tests_to_M3 branch 2 times, most recently from 88e90d7 to 7c8aaab Compare June 24, 2025 08:06
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits:) Thanks for helping improve the test coverage!

alignment: FloatingLabelAlignment.center,
),
);
// (decorator (800) / icon (40)) / 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// (decorator (800) / icon (40)) / 2
// (decorator (800) - icon (40)) / 2

borderIsOutline: true,
),
);
// (decorator (800) / icon (40)) / 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// (decorator (800) / icon (40)) / 2
// (decorator (800) - icon (40)) / 2

@bleroux bleroux force-pushed the migrate_InputDecoration.floatingLabelAlignment_tests_to_M3 branch from 7c8aaab to 7f9848f Compare June 25, 2025 08:18
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
Copy link
Contributor

auto-submit bot commented Jun 25, 2025

autosubmit label was removed for flutter/flutter/170903, because Pull request flutter/flutter/170903 is not in a mergeable state.

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
Copy link
Contributor

auto-submit bot commented Jun 25, 2025

autosubmit label was removed for flutter/flutter/170903, because Pull request flutter/flutter/170903 is not in a mergeable state.

@bleroux bleroux force-pushed the migrate_InputDecoration.floatingLabelAlignment_tests_to_M3 branch from 7f9848f to da704e8 Compare June 25, 2025 09:30
@QuncCccccc QuncCccccc force-pushed the migrate_InputDecoration.floatingLabelAlignment_tests_to_M3 branch from da704e8 to 3f578d9 Compare June 25, 2025 17:30
@bleroux bleroux force-pushed the migrate_InputDecoration.floatingLabelAlignment_tests_to_M3 branch from 1e946d8 to 9863d2e Compare June 26, 2025 06:13
@QuncCccccc QuncCccccc force-pushed the migrate_InputDecoration.floatingLabelAlignment_tests_to_M3 branch from 9863d2e to dc2245c Compare June 26, 2025 18:13
@QuncCccccc
Copy link
Contributor

The google testing failures show infra error and look unrelated to this PR changes. Rebased master and rerunning the tests.

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 26, 2025
Merged via the queue into flutter:master with commit 5bb4825 Jun 26, 2025
71 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2025
@bleroux bleroux deleted the migrate_InputDecoration.floatingLabelAlignment_tests_to_M3 branch June 26, 2025 19:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
…ter#170903)

## Description

This PR adds missing M3 tests for
InputDecoration.floatingLabelAlignment.

## Related Issue

Will help to complete flutter#168981

## Tests

Adds 8 tests (based on existing M2 tests).
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants