-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Add missing M3 tests for InputDecoration.floatingLabelAlignment #170903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing M3 tests for InputDecoration.floatingLabelAlignment #170903
Conversation
88e90d7
to
7c8aaab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits:) Thanks for helping improve the test coverage!
alignment: FloatingLabelAlignment.center, | ||
), | ||
); | ||
// (decorator (800) / icon (40)) / 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// (decorator (800) / icon (40)) / 2 | |
// (decorator (800) - icon (40)) / 2 |
borderIsOutline: true, | ||
), | ||
); | ||
// (decorator (800) / icon (40)) / 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// (decorator (800) / icon (40)) / 2 | |
// (decorator (800) - icon (40)) / 2 |
7c8aaab
to
7f9848f
Compare
autosubmit label was removed for flutter/flutter/170903, because Pull request flutter/flutter/170903 is not in a mergeable state. |
autosubmit label was removed for flutter/flutter/170903, because Pull request flutter/flutter/170903 is not in a mergeable state. |
7f9848f
to
da704e8
Compare
da704e8
to
3f578d9
Compare
1e946d8
to
9863d2e
Compare
9863d2e
to
dc2245c
Compare
The google testing failures show infra error and look unrelated to this PR changes. Rebased master and rerunning the tests. |
…ter#170903) ## Description This PR adds missing M3 tests for InputDecoration.floatingLabelAlignment. ## Related Issue Will help to complete flutter#168981 ## Tests Adds 8 tests (based on existing M2 tests).
Description
This PR adds missing M3 tests for InputDecoration.floatingLabelAlignment.
Related Issue
Will help to complete #168981
Tests
Adds 8 tests (based on existing M2 tests).