Skip to content

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Jun 23, 2025

Description

Reland #170905 which was reverted in #170994

The change from #170905 had to be adjusted with a change which landed just before (#168981).

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 23, 2025
@bleroux bleroux requested a review from ksokolovskyi June 23, 2025 09:00
Copy link
Contributor

@ksokolovskyi ksokolovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 23, 2025
Merged via the queue into flutter:master with commit 99d909a Jun 23, 2025
70 of 71 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025
@bleroux bleroux deleted the reland_fix_InputDecoration_floatingLabelBehavior_is_not_inherited branch June 23, 2025 10:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 23, 2025
flutter/flutter@0ab008a...d733bea

2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948)
2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9478)

flutter/flutter@0ab008a...d733bea

2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948)
2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
…lutter#170995)

## Description

Reland flutter#170905 which was reverted
in flutter#170994

The change from flutter#170905 had to be
adjusted with a change which landed just before
(flutter#168981).
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9478)

flutter/flutter@0ab008a...d733bea

2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013)
2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007)
2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816)
2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948)
2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004)
2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006)
2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000)
2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992)
2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517)
2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994)
2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905)
2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990)
2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840)
2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants