Revert skipped hot restart test that fails on LUCI. #170947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
approved these changes
Jun 23, 2025
|
Where is this failing?
We shouldn't be loading canvaskit from gstatic in our tests. The fix is to load the local canvaskit file. I'll look into fixing this. |
|
I think #171013 should fix the failures you're seeing, @biggs0125. |
|
Fix found via #171013 so closing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test being edited here was combined in the following change:
817fa97
This has caused failures in LUCI for these tests. The error looks like:
Previously the second of these split tests was marked as
skip: true. This was because the test has historically failed on LUCI. It passes locally but does not work when run on LUCI:#110879
This change splits back out the tests and skips the second of them until they can be fixed.