Skip to content

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jun 19, 2025

@bkonyi bkonyi requested a review from kenzieschmoll June 19, 2025 16:48
@bkonyi bkonyi added the cp: stable cherry pick this pull request to stable release candidate branch label Jun 19, 2025
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 19, 2025
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jun 19, 2025
Merged via the queue into master with commit 6fe40ca Jun 19, 2025
143 checks passed
@auto-submit auto-submit bot deleted the roll_dds_5.0.3 branch June 19, 2025 19:33
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 20, 2025
flutter/flutter@85a9b4f...c7362b4

2025-06-20 43054281+camsim99@users.noreply.github.com [Android] Add a way to request new `Surface`s from `SurfaceProducer` and avoid `SurfaceProducer` returning invalid `Surface` (flutter/flutter#169899)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from cc2f604acb05 to a554bdd0a2cc (1 revision) (flutter/flutter#170912)
2025-06-20 robert.ancell@canonical.com Set the background in the Linux template (flutter/flutter#170841)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 2fc58cffe69b to f1e68950ea7b (2 revisions) (flutter/flutter#170914)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 8a710de2a1d3 to 2fc58cffe69b (2 revisions) (flutter/flutter#170906)
2025-06-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#170907)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 2ac2476b0bcb to 8a710de2a1d3 (2 revisions) (flutter/flutter#170900)
2025-06-20 fluttergithubbot@gmail.com Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be flaky (flutter/flutter#170785)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) (flutter/flutter#170895)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) (flutter/flutter#170890)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from bce9abe03175 to 6a4b11760906 (1 revision) (flutter/flutter#170884)
2025-06-19 bkonyi@google.com [ Tool ] Roll DDS 5.0.3 (flutter/flutter#170880)
2025-06-19 engine-flutter-autoroll@skia.org Roll Packages from 715a0a5 to 0ec4053 (8 revisions) (flutter/flutter#170879)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 794936b23812 to 61c89daa3888 (7 revisions) (flutter/flutter#170878)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bkonyi bkonyi added cp: stable cherry pick this pull request to stable release candidate branch and removed cp: stable cherry pick this pull request to stable release candidate branch labels Jun 23, 2025
@flutteractionsbot
Copy link

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

bkonyi added a commit that referenced this pull request Jun 23, 2025
bkonyi added a commit that referenced this pull request Jun 23, 2025
auto-submit bot pushed a commit that referenced this pull request Jun 23, 2025
### Issue Link:
dart-lang/sdk#60851

### Changelog Description:

Fixes unhandled exception on application shutdown in the debug adapter used by IDEs.

### Impact Description:

The Debug Adapter (DAP) could crash if it is waiting on specific RPCs from a target application while the application is shutting down.

### Workaround:
None.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:

This bug is extremely hard to reproduce reliably. Catching `RPCError` and checking for the correct error code related to the VM service disappearing is simple and low risk.
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9466)

flutter/flutter@85a9b4f...c7362b4

2025-06-20 43054281+camsim99@users.noreply.github.com [Android] Add a way to request new `Surface`s from `SurfaceProducer` and avoid `SurfaceProducer` returning invalid `Surface` (flutter/flutter#169899)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from cc2f604acb05 to a554bdd0a2cc (1 revision) (flutter/flutter#170912)
2025-06-20 robert.ancell@canonical.com Set the background in the Linux template (flutter/flutter#170841)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 2fc58cffe69b to f1e68950ea7b (2 revisions) (flutter/flutter#170914)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 8a710de2a1d3 to 2fc58cffe69b (2 revisions) (flutter/flutter#170906)
2025-06-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#170907)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 2ac2476b0bcb to 8a710de2a1d3 (2 revisions) (flutter/flutter#170900)
2025-06-20 fluttergithubbot@gmail.com Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be flaky (flutter/flutter#170785)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) (flutter/flutter#170895)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) (flutter/flutter#170890)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from bce9abe03175 to 6a4b11760906 (1 revision) (flutter/flutter#170884)
2025-06-19 bkonyi@google.com [ Tool ] Roll DDS 5.0.3 (flutter/flutter#170880)
2025-06-19 engine-flutter-autoroll@skia.org Roll Packages from 715a0a5 to 0ec4053 (8 revisions) (flutter/flutter#170879)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 794936b23812 to 61c89daa3888 (7 revisions) (flutter/flutter#170878)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9466)

flutter/flutter@85a9b4f...c7362b4

2025-06-20 43054281+camsim99@users.noreply.github.com [Android] Add a way to request new `Surface`s from `SurfaceProducer` and avoid `SurfaceProducer` returning invalid `Surface` (flutter/flutter#169899)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from cc2f604acb05 to a554bdd0a2cc (1 revision) (flutter/flutter#170912)
2025-06-20 robert.ancell@canonical.com Set the background in the Linux template (flutter/flutter#170841)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 2fc58cffe69b to f1e68950ea7b (2 revisions) (flutter/flutter#170914)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 8a710de2a1d3 to 2fc58cffe69b (2 revisions) (flutter/flutter#170906)
2025-06-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#170907)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 2ac2476b0bcb to 8a710de2a1d3 (2 revisions) (flutter/flutter#170900)
2025-06-20 fluttergithubbot@gmail.com Marks Linux_pixel_7pro dynamic_path_stroke_tessellation_perf__timeline_summary to be flaky (flutter/flutter#170785)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from 6a4b11760906 to cc2f604acb05 (1 revision) (flutter/flutter#170895)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 61c89daa3888 to 2ac2476b0bcb (4 revisions) (flutter/flutter#170890)
2025-06-19 engine-flutter-autoroll@skia.org Roll Dart SDK from bce9abe03175 to 6a4b11760906 (1 revision) (flutter/flutter#170884)
2025-06-19 bkonyi@google.com [ Tool ] Roll DDS 5.0.3 (flutter/flutter#170880)
2025-06-19 engine-flutter-autoroll@skia.org Roll Packages from 715a0a5 to 0ec4053 (8 revisions) (flutter/flutter#170879)
2025-06-19 engine-flutter-autoroll@skia.org Roll Skia from 794936b23812 to 61c89daa3888 (7 revisions) (flutter/flutter#170878)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp: stable cherry pick this pull request to stable release candidate branch tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ DAP ] Unhandled Service connection disposed RPCErrors in IsolateManager
3 participants