Skip to content

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jun 18, 2025

We are still executing < 40s and I'm down to about 98 errors.

  • cleaned up the output
  • added include_filter flag to help debugging
  • added a lot of instances to the data directory

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jun 18, 2025
@gaaclarke gaaclarke marked this pull request as ready for review June 18, 2025 23:41
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2025
Copy link
Contributor

auto-submit bot commented Jun 19, 2025

autosubmit label was removed for flutter/flutter/170845, because - The status or check suite Linux build_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke added this pull request to the merge queue Jun 20, 2025
Merged via the queue into flutter:master with commit 3743216 Jun 20, 2025
176 checks passed
@gaaclarke gaaclarke deleted the license_cpp_jun17 branch June 20, 2025 17:32
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 23, 2025
flutter/flutter@c7362b4...0ab008a

2025-06-22 engine-flutter-autoroll@skia.org Roll Skia from 203469ef4672 to fcd1c55da9cc (1 revision) (flutter/flutter#170986)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from e5db5e0f81ba to 98db1db5ff65 (2 revisions) (flutter/flutter#170979)
2025-06-21 bruno.leroux@gmail.com Normalize input decoration theme (flutter/flutter#168981)
2025-06-21 engine-flutter-autoroll@skia.org Roll Skia from dceb857b1c47 to 203469ef4672 (1 revision) (flutter/flutter#170959)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 6325aeacaef4 to e5db5e0f81ba (1 revision) (flutter/flutter#170958)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from a6a3d65e33d7 to 6325aeacaef4 (2 revisions) (flutter/flutter#170955)
2025-06-21 engine-flutter-autoroll@skia.org Roll Skia from 773188560221 to dceb857b1c47 (1 revision) (flutter/flutter#170954)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 750eaa028445 to a6a3d65e33d7 (1 revision) (flutter/flutter#170953)
2025-06-21 hidea@users.noreply.github.com Fix the Japanese IME problem on macOS reported in the following issue. (flutter/flutter#166291)
2025-06-21 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from IfPORaYjQ2zP4bcq-... to 2wEtX_lDNhHhDNsP6... (flutter/flutter#170946)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 104460420c48 to 773188560221 (2 revisions) (flutter/flutter#170942)
2025-06-20 huy@nevercode.io Normalize AppBarTheme (flutter/flutter#169130)
2025-06-20 victorsanniay@gmail.com Close CupertinoContextMenu overlay if the widget is disposed or a new route is pushed (flutter/flutter#170186)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from a554bdd0a2cc to 750eaa028445 (1 revision) (flutter/flutter#170933)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from b638003de37e to 104460420c48 (1 revision) (flutter/flutter#170932)
2025-06-20 engine-flutter-autoroll@skia.org Roll Packages from 0ec4053 to 7f41e75 (1 revision) (flutter/flutter#170925)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from f1e68950ea7b to b638003de37e (5 revisions) (flutter/flutter#170923)
2025-06-20 30870216+gaaclarke@users.noreply.github.com [licenses_cpp] jun17 (flutter/flutter#170845)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9472)

flutter/flutter@c7362b4...0ab008a

2025-06-22 engine-flutter-autoroll@skia.org Roll Skia from 203469ef4672 to fcd1c55da9cc (1 revision) (flutter/flutter#170986)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from e5db5e0f81ba to 98db1db5ff65 (2 revisions) (flutter/flutter#170979)
2025-06-21 bruno.leroux@gmail.com Normalize input decoration theme (flutter/flutter#168981)
2025-06-21 engine-flutter-autoroll@skia.org Roll Skia from dceb857b1c47 to 203469ef4672 (1 revision) (flutter/flutter#170959)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 6325aeacaef4 to e5db5e0f81ba (1 revision) (flutter/flutter#170958)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from a6a3d65e33d7 to 6325aeacaef4 (2 revisions) (flutter/flutter#170955)
2025-06-21 engine-flutter-autoroll@skia.org Roll Skia from 773188560221 to dceb857b1c47 (1 revision) (flutter/flutter#170954)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 750eaa028445 to a6a3d65e33d7 (1 revision) (flutter/flutter#170953)
2025-06-21 hidea@users.noreply.github.com Fix the Japanese IME problem on macOS reported in the following issue. (flutter/flutter#166291)
2025-06-21 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from IfPORaYjQ2zP4bcq-... to 2wEtX_lDNhHhDNsP6... (flutter/flutter#170946)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 104460420c48 to 773188560221 (2 revisions) (flutter/flutter#170942)
2025-06-20 huy@nevercode.io Normalize AppBarTheme (flutter/flutter#169130)
2025-06-20 victorsanniay@gmail.com Close CupertinoContextMenu overlay if the widget is disposed or a new route is pushed (flutter/flutter#170186)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from a554bdd0a2cc to 750eaa028445 (1 revision) (flutter/flutter#170933)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from b638003de37e to 104460420c48 (1 revision) (flutter/flutter#170932)
2025-06-20 engine-flutter-autoroll@skia.org Roll Packages from 0ec4053 to 7f41e75 (1 revision) (flutter/flutter#170925)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from f1e68950ea7b to b638003de37e (5 revisions) (flutter/flutter#170923)
2025-06-20 30870216+gaaclarke@users.noreply.github.com [licenses_cpp] jun17 (flutter/flutter#170845)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
We are still executing < 40s and I'm down to about 98 errors.

- cleaned up the output
- added include_filter flag to help debugging
- added a lot of instances to the data directory

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9472)

flutter/flutter@c7362b4...0ab008a

2025-06-22 engine-flutter-autoroll@skia.org Roll Skia from 203469ef4672 to fcd1c55da9cc (1 revision) (flutter/flutter#170986)
2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from e5db5e0f81ba to 98db1db5ff65 (2 revisions) (flutter/flutter#170979)
2025-06-21 bruno.leroux@gmail.com Normalize input decoration theme (flutter/flutter#168981)
2025-06-21 engine-flutter-autoroll@skia.org Roll Skia from dceb857b1c47 to 203469ef4672 (1 revision) (flutter/flutter#170959)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 6325aeacaef4 to e5db5e0f81ba (1 revision) (flutter/flutter#170958)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from a6a3d65e33d7 to 6325aeacaef4 (2 revisions) (flutter/flutter#170955)
2025-06-21 engine-flutter-autoroll@skia.org Roll Skia from 773188560221 to dceb857b1c47 (1 revision) (flutter/flutter#170954)
2025-06-21 engine-flutter-autoroll@skia.org Roll Dart SDK from 750eaa028445 to a6a3d65e33d7 (1 revision) (flutter/flutter#170953)
2025-06-21 hidea@users.noreply.github.com Fix the Japanese IME problem on macOS reported in the following issue. (flutter/flutter#166291)
2025-06-21 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from IfPORaYjQ2zP4bcq-... to 2wEtX_lDNhHhDNsP6... (flutter/flutter#170946)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from 104460420c48 to 773188560221 (2 revisions) (flutter/flutter#170942)
2025-06-20 huy@nevercode.io Normalize AppBarTheme (flutter/flutter#169130)
2025-06-20 victorsanniay@gmail.com Close CupertinoContextMenu overlay if the widget is disposed or a new route is pushed (flutter/flutter#170186)
2025-06-20 engine-flutter-autoroll@skia.org Roll Dart SDK from a554bdd0a2cc to 750eaa028445 (1 revision) (flutter/flutter#170933)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from b638003de37e to 104460420c48 (1 revision) (flutter/flutter#170932)
2025-06-20 engine-flutter-autoroll@skia.org Roll Packages from 0ec4053 to 7f41e75 (1 revision) (flutter/flutter#170925)
2025-06-20 engine-flutter-autoroll@skia.org Roll Skia from f1e68950ea7b to b638003de37e (5 revisions) (flutter/flutter#170923)
2025-06-20 30870216+gaaclarke@users.noreply.github.com [licenses_cpp] jun17 (flutter/flutter#170845)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine related. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants