Run pub get post-processing for each package in workspace #170517

sigurdm · 2025-06-12T12:08:51Z

Fixes #161927

…pace

packages/flutter_tools/lib/src/dart/pub.dart

bkonyi · 2025-06-12T15:19:15Z

packages/flutter_tools/lib/src/package_graph.dart

+    if (list == null) {
+      return <String>[];
+    }
+    if (list is! List<Object?>) {


I think this function can just be if section not being present is an error:

if (map case {section: final List<String>? list when map.containsKey(section)) { return list ?? <String>[]; } throw FormatException('Expected `$section` to be `List<String>?`, got `${map[section]}');

When trying that i get: Key expressions in map patterns must be constants.

Oh that's annoying... Honestly, I'd remove this helper and just use the pattern above in its place with the constant keys. This helper function is doing a lot of unnecessary checks.

One more thing. When you read json the List doesn't become a List<String> it is a List<Object?>, and you need to validate each item separately and cast the list. I don't think that can be done with pattern matching...

This definitely works with pattern matching:

final json = <String, Object?>{ 'foo': <String>['bar', 'baz'], }; final jsonWithNull = <String, Object?>{ 'foo': <String?>['bar', 'baz', null], }; void main() { if (json case {'foo': final List<String> list}) { print('Destructured JSON list: $list Runtime type: ${list.runtimeType}'); } else { print('Failed to destructure $json'); } if (jsonWithNull case {'foo': final List<String> list}) { print('Destructured JSON list: $list Runtime type: ${list.runtimeType}'); } else { print('Failed to destructure $jsonWithNull'); } if (jsonWithNull case {'foo': final List<String?> list}) { print('Destructured JSON list: $list Runtime type: ${list.runtimeType}'); } else { print('Failed to destructure $jsonWithNull'); } }

Outputs:

Destructured JSON list: [bar, baz] Runtime type: List<String> Failed to destructure {foo: [bar, baz, null]} Destructured JSON list: [bar, baz, null] Runtime type: List<String?>

Yes, but when you read json, it doesn't type the lists as <String>[]. but List<dynamic> (which matches List<Object?>).

import 'dart:convert'; main() { switch (jsonDecode('["A", "B", "C"]')) { case final List<String> a: print('List of String'); case final List<Object?> a: print('List of Object'); case final a: print('Something else ${a.runtimeType}'); } }

Ah, good point... that's really annoying behavior since map patterns are supposed to be most useful for JSON destructuring...

Anyway, this approach would be less verbose than the current one:

List<String> _parseList(Map<String, Object?> map, String section) { final Object? result = map[section]; try { return (result as List<Object?>?)?.cast<String>() ?? <String>[]; } on TypeError { throw FormatException( 'Expected `$section` to be `List<String>`, got ${result.runtimeType}', ); } }

packages/flutter_tools/lib/src/commands/packages.dart

…pace

matanlurey

LGTM, but defer final approval to Ben.

bkonyi · 2025-06-16T20:48:37Z

Once we remove _parseList, this will LGTM.

…pace

bkonyi

Thanks for humoring me 😅 LGTM!

sigurdm · 2025-06-23T09:50:49Z

@bkonyi thanks! Yeah - async code review is tough sometimes. But thanks for being insistent on code quality!

…lutter/flutter#170517)

flutter/flutter@0ab008a...d733bea 2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948) 2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9478) flutter/flutter@0ab008a...d733bea 2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948) 2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…0517) Fixes flutter#161927

…r#9478) flutter/flutter@0ab008a...d733bea 2025-06-23 mdebbar@google.com Add `--no-web-resources-cdn` to all web integration tests (flutter/flutter#171013) 2025-06-23 bkonyi@google.com [ Tool ] Roll package:dds 5.0.4 (flutter/flutter#171007) 2025-06-23 jessiewong401@gmail.com Update Docs to Warn Users Edge-To-Edge opt out is being deprecated for Android 16+ (API 36+) (flutter/flutter#170816) 2025-06-23 30870216+gaaclarke@users.noreply.github.com License cpp jun20 (flutter/flutter#170948) 2025-06-23 mdebbar@google.com Un-bringup `Linux web_tool_tests` (flutter/flutter#171004) 2025-06-23 engine-flutter-autoroll@skia.org Roll Packages from 7f41e75 to 02770da (5 revisions) (flutter/flutter#171006) 2025-06-23 engine-flutter-autoroll@skia.org Roll Dart SDK from bb16990911b5 to a09de0d3556c (2 revisions) (flutter/flutter#171000) 2025-06-23 bruno.leroux@gmail.com Reland: Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170995) 2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from aef4081157f0 to 0311837abe86 (1 revision) (flutter/flutter#170992) 2025-06-23 sigurdm@google.com Run pub get post-processing for each package in workspace (flutter/flutter#170517) 2025-06-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix InputDecoration.floatingLabelBehavior is not inherited (#170905)" (flutter/flutter#170994) 2025-06-23 bruno.leroux@gmail.com Fix InputDecoration.floatingLabelBehavior is not inherited (flutter/flutter#170905) 2025-06-23 engine-flutter-autoroll@skia.org Roll Skia from fcd1c55da9cc to aef4081157f0 (1 revision) (flutter/flutter#170990) 2025-06-22 robert.ancell@canonical.com Clear background in the GTK layer, instead of OpenGL (flutter/flutter#170840) 2025-06-22 robert.ancell@canonical.com Show window on first frame on Linux (flutter/flutter#170844) 2025-06-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 98db1db5ff65 to bb16990911b5 (1 revision) (flutter/flutter#170988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/flutter#170517)

sigurdm added 2 commits June 12, 2025 12:05

Run pub get postprocessing for each package in workspace

6b5b67c

Merge remote-tracking branch 'origin/master' into resolve_whole_works…

6a58fb4

…pace

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 12, 2025

sigurdm requested review from matanlurey and bkonyi June 12, 2025 13:10

bkonyi reviewed Jun 12, 2025

View reviewed changes

sigurdm added 2 commits June 13, 2025 12:57

Remove debug code

2cce586

Merge remote-tracking branch 'origin/master' into resolve_whole_works…

65ce05c

…pace

matanlurey reviewed Jun 16, 2025

View reviewed changes

sigurdm added 4 commits June 20, 2025 08:14

refactor _parseList

6fcbf2d

Merge remote-tracking branch 'origin/master' into resolve_whole_works…

6b0e4c9

…pace

refactor _parseList2

634632e

Typo

0574ada

bkonyi approved these changes Jun 20, 2025

View reviewed changes

sigurdm added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025

auto-submit bot added this pull request to the merge queue Jun 23, 2025

Merged via the queue into flutter:master with commit a0e30bf Jun 23, 2025
138 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

b0ede70

…lutter/flutter#170517)

engine-flutter-autoroll mentioned this pull request Jun 23, 2025

Roll Flutter from 0ab008a17228 to 99d909aed0f8 (9 revisions) flutter/packages#9474

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

3dc0007

…lutter/flutter#170517)

engine-flutter-autoroll mentioned this pull request Jun 23, 2025

Roll Flutter from 0ab008a17228 to ff1be7d67ed2 (10 revisions) flutter/packages#9475

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

b9652a4

…lutter/flutter#170517)

engine-flutter-autoroll mentioned this pull request Jun 23, 2025

Roll Flutter from 0ab008a17228 to 6983043d3bda (11 revisions) flutter/packages#9476

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

e563656

…lutter/flutter#170517)

engine-flutter-autoroll mentioned this pull request Jun 23, 2025

Roll Flutter from 0ab008a17228 to 20969cf26463 (14 revisions) flutter/packages#9477

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

f939fe3

…lutter/flutter#170517)

engine-flutter-autoroll mentioned this pull request Jun 23, 2025

Roll Flutter from 0ab008a17228 to d733bea58c1a (16 revisions) flutter/packages#9478

Merged

mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025

Run pub get post-processing for each package in workspace (flutter#17…

36f49dc

…0517) Fixes flutter#161927

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

99c5bb8

…lutter/flutter#170517)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

2258165

…lutter/flutter#170517)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

a67c78d

…lutter/flutter#170517)

Peetee06 mentioned this pull request Aug 15, 2025

request: pub workspaces invertase/melos#747

Closed

1 task

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

6d6bde1

…lutter/flutter#170517)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

a0e30bf18 Run pub get post-processing for each package in workspace (f…

7dd2aa0

…lutter/flutter#170517)

crasowas mentioned this pull request Aug 19, 2025

MissingPluginException when using pub workspace #173842

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Run pub get post-processing for each package in workspace #170517

Run pub get post-processing for each package in workspace #170517

Uh oh!

sigurdm commented Jun 12, 2025

Uh oh!

Uh oh!

bkonyi Jun 12, 2025

Uh oh!

sigurdm Jun 13, 2025

Uh oh!

bkonyi Jun 13, 2025

Uh oh!

sigurdm Jun 17, 2025

Uh oh!

bkonyi Jun 17, 2025

Uh oh!

sigurdm Jun 19, 2025

Uh oh!

bkonyi Jun 19, 2025

Uh oh!

Uh oh!

matanlurey left a comment

Uh oh!

bkonyi commented Jun 16, 2025

Uh oh!

bkonyi left a comment

Uh oh!

Uh oh!

sigurdm commented Jun 23, 2025

Uh oh!

Uh oh!

Run pub get post-processing for each package in workspace #170517

Run pub get post-processing for each package in workspace #170517

Uh oh!

Conversation

sigurdm commented Jun 12, 2025

Uh oh!

Uh oh!

bkonyi Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

sigurdm Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

sigurdm Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

sigurdm Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

bkonyi commented Jun 16, 2025

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sigurdm commented Jun 23, 2025

Uh oh!

Uh oh!