Hi @MaherSafadii can you confirm if this fixes all the remaining issues in #163020? Thanks for pointing them out there.

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169708 at sha fea80aa

Hi @MaherSafadii can you confirm if this fixes all the remaining issues in #163020? Thanks for pointing them out there.

Sure I'll check them no problem, I'm glad you found the notes useful.

the placeholder text colors are correct now.

the color of the search field in dark mode seems to be wrong in dark mode, it was fine before the last stable, it's at least when I noticed it so I don't know what previous PR caused it exactly, I noticed this also occurring on the latest stable release too,

also there seems to be an issue with the previous pages title, it only happens when autoImplyleading is set to false, when you manually drag to pop the page the previous large title isn't visible, it shows as soon as the popping finishes when you let go as shown here:

and a note on how you compared the native and flutter side for the CupertinoSliverNavigationBar, comparing small things like padding isn't ideal using the app switcher, because the cards have larger scale the more they are to the front, keep this in mind for any future comparisons too, I tried doing a comparison once and realized this then.

the title padding is now a bit to little now, here are the comparisons:

Native:

Flutter - with these new changes:

Flutter - old:

but in my opinion at this point of time, only week away until WWDC where iOS is getting a complete UI redesign, the padding in minimal and barely noticeable (things look fine as of for now), so it might not be worth fine tuning it to the last pixel right now.

Thanks for the response @MaherSafadii.

the color of the search field in dark mode seems to be wrong in dark mode, it was fine before the last stable, it's at least when I noticed it so I don't know what previous PR caused it exactly

I'm not able to reproduce this with the changes in this PR, can you share some sample code? The PR description has an image of the search field in dark mode and it looks okay.

also there seems to be an issue with the previous pages title, it only happens when autoImplyleading is set to false, when you manually drag to pop the page the previous large title isn't visible, it shows as soon as the popping finishes when you let go

This case is a little tricky because it's a known issue in SwiftUI that if there's no leading/back button, the edge back swipe gesture is disabled. But I agree the transition looks jarring. I can enable the large title to animate in transition the same way it would if there is a leading but not a back button, that should help mitigate this.

the padding in minimal and barely noticeable (things look fine as of for now), so it might not be worth fine tuning it to the last pixel right now.

I agree. Especially since this is technically a breaking change, so we should aim to get it right once and for all. I will revert to the previous padding.

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169708 at sha 47eaea8

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #169708 at sha 2fff81f

Golden changes are due to the placeholder color change.