Skip to content

Remove handling of the legacy .flutter-plugins file in PluginHandler.kt. #169317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

Remove handling of the legacy .flutter-plugins file in PluginHandler.kt. #169317

merged 2 commits into from
May 23, 2025

Conversation

matanlurey
Copy link
Contributor

As of #169283 it's impossible for the .flutter-plugins file to exist outside of unit tests.

@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels May 23, 2025
@matanlurey matanlurey requested a review from gmackall May 23, 2025 03:49
@matanlurey matanlurey marked this pull request as ready for review May 23, 2025 03:49
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025
gmackall
gmackall approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@auto-submit auto-submit bot added this pull request to the merge queue May 23, 2025
Merged via the queue into master with commit 5f99c89 May 23, 2025
149 checks passed
@auto-submit auto-submit bot deleted the GradleKt-remove-legacyPluginHandler branch May 23, 2025 17:36
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 24, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2025
@engine-flutter-autoroll
5f99c893b Remove handling of the legacy .flutter-plugins file in `P…
e533e47 
…luginHandler.kt`. (flutter/flutter#169317)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 24, 2025
@engine-flutter-autoroll
Roll Flutter from 85564cbba9e7 to 60050a0b4d56 (17 revisions) (#9318)
c637ecb 
flutter/flutter@85564cb...60050a0

2025-05-24 engine-flutter-autoroll@skia.org Roll Skia from 0834eea9de33 to 91dc88dc70e5 (1 revision) (flutter/flutter#169414)
2025-05-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 0a6b16a55b9e to 7dab9bffe1f7 (1 revision) (flutter/flutter#169406)
2025-05-24 victorsanniay@gmail.com Correct calculation for CupertinoTextSelectionToolbar vertical position (flutter/flutter#169308)
2025-05-24 victorsanniay@gmail.com Baseline-align CupertinoTextField placeholder (flutter/flutter#166952)
2025-05-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 8354914ef97b to 0a6b16a55b9e (3 revisions) (flutter/flutter#169403)
2025-05-24 bkonyi@google.com Start removing Observatory support and references (flutter/flutter#169216)
2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from f42bb59753fe to 0834eea9de33 (3 revisions) (flutter/flutter#169393)
2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from 956fd8b14e22 to f42bb59753fe (2 revisions) (flutter/flutter#169379)
2025-05-23 dkwingsmt@users.noreply.github.com [Engine] Fast blurring algorithm for RSuperellipse (flutter/flutter#169187)
2025-05-23 matanlurey@users.noreply.github.com Add a page describing best CI practices for `flutter`-org repos (flutter/flutter#169364)
2025-05-23 mdebbar@google.com Revert "Mark web_tool_tests_1_2 as bringup." (flutter/flutter#169361)
2025-05-23 34871572+gmackall@users.noreply.github.com Add changelog section for 3.32.0 and 3.32.1, and add note for ndk checking cherry pick (flutter/flutter#169369)
2025-05-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 085f110ecf33 to 8354914ef97b (1 revision) (flutter/flutter#169349)
2025-05-23 matanlurey@users.noreply.github.com Remove handling of the legacy `.flutter-plugins` file in `PluginHandler.kt`. (flutter/flutter#169317)
2025-05-23 dumazy@gmail.com Use baseUri of WebAssetServer for reload_scripts.json (flutter/flutter#169267)
2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use pub workspace (#168662)" (flutter/flutter#169357)
2025-05-23 mosum@google.com Use pub workspace (flutter/flutter#168662)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zeqinjie pushed a commit to zeqinjie/flutter that referenced this pull request Jun 5, 2025
@zhengzeqin007
Merge branch 'master' into fix_top_left
ffdea9b 
* master: (125 commits)
  Roll Fuchsia Linux SDK from XtPp9bBW49iDJ0wbA... to -eo2JqnJBauuGSzoW... (flutter#169424)
  Roll Skia from 91dc88dc70e5 to 443f5257f382 (1 revision) (flutter#169422)
  Roll Skia from 0834eea9de33 to 91dc88dc70e5 (1 revision) (flutter#169414)
  Roll Dart SDK from 0a6b16a55b9e to 7dab9bffe1f7 (1 revision) (flutter#169406)
  Correct calculation for CupertinoTextSelectionToolbar vertical position (flutter#169308)
  Baseline-align CupertinoTextField placeholder (flutter#166952)
  Roll Dart SDK from 8354914ef97b to 0a6b16a55b9e (3 revisions) (flutter#169403)
  Start removing Observatory support and references (flutter#169216)
  Roll Skia from f42bb59753fe to 0834eea9de33 (3 revisions) (flutter#169393)
  Roll Skia from 956fd8b14e22 to f42bb59753fe (2 revisions) (flutter#169379)
  [Engine] Fast blurring algorithm for RSuperellipse (flutter#169187)
  Add a page describing best CI practices for `flutter`-org repos (flutter#169364)
  Revert "Mark web_tool_tests_1_2 as bringup." (flutter#169361)
  Add changelog section for 3.32.0 and 3.32.1, and add note for ndk checking cherry pick (flutter#169369)
  Roll Dart SDK from 085f110ecf33 to 8354914ef97b (1 revision) (flutter#169349)
  Remove handling of the legacy `.flutter-plugins` file in `PluginHandler.kt`. (flutter#169317)
  Use baseUri of WebAssetServer for reload_scripts.json (flutter#169267)
  Reverts "Use pub workspace (flutter#168662)" (flutter#169357)
  Use pub workspace (flutter#168662)
  Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter#169276)" (flutter#169347)
  ...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 85564cbba9e7 to 60050a0b4d56 (17 revisions) (flutte…
96fb3e0 
…r#9318)

flutter/flutter@85564cb...60050a0

2025-05-24 engine-flutter-autoroll@skia.org Roll Skia from 0834eea9de33 to 91dc88dc70e5 (1 revision) (flutter/flutter#169414)
2025-05-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 0a6b16a55b9e to 7dab9bffe1f7 (1 revision) (flutter/flutter#169406)
2025-05-24 victorsanniay@gmail.com Correct calculation for CupertinoTextSelectionToolbar vertical position (flutter/flutter#169308)
2025-05-24 victorsanniay@gmail.com Baseline-align CupertinoTextField placeholder (flutter/flutter#166952)
2025-05-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 8354914ef97b to 0a6b16a55b9e (3 revisions) (flutter/flutter#169403)
2025-05-24 bkonyi@google.com Start removing Observatory support and references (flutter/flutter#169216)
2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from f42bb59753fe to 0834eea9de33 (3 revisions) (flutter/flutter#169393)
2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from 956fd8b14e22 to f42bb59753fe (2 revisions) (flutter/flutter#169379)
2025-05-23 dkwingsmt@users.noreply.github.com [Engine] Fast blurring algorithm for RSuperellipse (flutter/flutter#169187)
2025-05-23 matanlurey@users.noreply.github.com Add a page describing best CI practices for `flutter`-org repos (flutter/flutter#169364)
2025-05-23 mdebbar@google.com Revert "Mark web_tool_tests_1_2 as bringup." (flutter/flutter#169361)
2025-05-23 34871572+gmackall@users.noreply.github.com Add changelog section for 3.32.0 and 3.32.1, and add note for ndk checking cherry pick (flutter/flutter#169369)
2025-05-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 085f110ecf33 to 8354914ef97b (1 revision) (flutter/flutter#169349)
2025-05-23 matanlurey@users.noreply.github.com Remove handling of the legacy `.flutter-plugins` file in `PluginHandler.kt`. (flutter/flutter#169317)
2025-05-23 dumazy@gmail.com Use baseUri of WebAssetServer for reload_scripts.json (flutter/flutter#169267)
2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use pub workspace (#168662)" (flutter/flutter#169357)
2025-05-23 mosum@google.com Use pub workspace (flutter/flutter#168662)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from 85564cbba9e7 to 60050a0b4d56 (17 revisions) (flutte…
d1f8f45 
…r#9318)

flutter/flutter@85564cb...60050a0

2025-05-24 engine-flutter-autoroll@skia.org Roll Skia from 0834eea9de33 to 91dc88dc70e5 (1 revision) (flutter/flutter#169414)
2025-05-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 0a6b16a55b9e to 7dab9bffe1f7 (1 revision) (flutter/flutter#169406)
2025-05-24 victorsanniay@gmail.com Correct calculation for CupertinoTextSelectionToolbar vertical position (flutter/flutter#169308)
2025-05-24 victorsanniay@gmail.com Baseline-align CupertinoTextField placeholder (flutter/flutter#166952)
2025-05-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 8354914ef97b to 0a6b16a55b9e (3 revisions) (flutter/flutter#169403)
2025-05-24 bkonyi@google.com Start removing Observatory support and references (flutter/flutter#169216)
2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from f42bb59753fe to 0834eea9de33 (3 revisions) (flutter/flutter#169393)
2025-05-23 engine-flutter-autoroll@skia.org Roll Skia from 956fd8b14e22 to f42bb59753fe (2 revisions) (flutter/flutter#169379)
2025-05-23 dkwingsmt@users.noreply.github.com [Engine] Fast blurring algorithm for RSuperellipse (flutter/flutter#169187)
2025-05-23 matanlurey@users.noreply.github.com Add a page describing best CI practices for `flutter`-org repos (flutter/flutter#169364)
2025-05-23 mdebbar@google.com Revert "Mark web_tool_tests_1_2 as bringup." (flutter/flutter#169361)
2025-05-23 34871572+gmackall@users.noreply.github.com Add changelog section for 3.32.0 and 3.32.1, and add note for ndk checking cherry pick (flutter/flutter#169369)
2025-05-23 engine-flutter-autoroll@skia.org Roll Dart SDK from 085f110ecf33 to 8354914ef97b (1 revision) (flutter/flutter#169349)
2025-05-23 matanlurey@users.noreply.github.com Remove handling of the legacy `.flutter-plugins` file in `PluginHandler.kt`. (flutter/flutter#169317)
2025-05-23 dumazy@gmail.com Use baseUri of WebAssetServer for reload_scripts.json (flutter/flutter#169267)
2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use pub workspace (#168662)" (flutter/flutter#169357)
2025-05-23 mosum@google.com Use pub workspace (flutter/flutter#168662)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
5f99c893b Remove handling of the legacy .flutter-plugins file in `P…
b948f3c 
…luginHandler.kt`. (flutter/flutter#169317)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
5f99c893b Remove handling of the legacy .flutter-plugins file in `P…
76f93a8 
…luginHandler.kt`. (flutter/flutter#169317)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
5f99c893b Remove handling of the legacy .flutter-plugins file in `P…
c14a863 
…luginHandler.kt`. (flutter/flutter#169317)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
5f99c893b Remove handling of the legacy .flutter-plugins file in `P…
0278eba 
…luginHandler.kt`. (flutter/flutter#169317)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
5f99c893b Remove handling of the legacy .flutter-plugins file in `P…
9b6ebf5 
…luginHandler.kt`. (flutter/flutter#169317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmackall gmackall gmackall approved these changes

Assignees
No one assigned
Labels
platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matanlurey @gmackall