macOS,iOS: fix swift target triple #168749

cbracken · 2025-05-13T17:55:23Z

While unifying iOS and macOS gn configuration in #168517,
I failed to correctly merge the deployment target in the target triple,
resulting in it being incorrectly hardcoded to the macOS deployment
target. This corrects this to the correct value for the target_os of
the current compile.

Also gets rid of an unnecessary assertion; we already
assert(is_mac || is_ios) at the top of the file.

Issue: #167592

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

While unifying iOS and macOS gn configuration in flutter#168517, I failed to correctly merge the deployment target in the target triple, resulting in it being incorrectly hardcoded to the macOS deployment target. This corrects this to the correct value for the `target_os` of the current compile. Also gets rid of an unnecessary assertion; we already `assert(is_mac || is_ios)` at the top of the file. Issue: flutter#167592

hellohuanlin · 2025-05-13T18:06:07Z

engine/src/build/config/darwin/BUILD.gn

  }
-  _target_triplet = "$_triplet_cpu-$_triplet_os$mac_deployment_target$_triplet_environment"
+  _target_triplet = "$_triplet_cpu-$_triplet_os$_deployment_target$_triplet_environment"


sanity check: there's a - between cpu & os, but not other places?

See line 45 above; there's a - between apple-ios and simulator if it's a simulator build. So the full "triplet" is arm64-apple-ios-simulator in that case. Otherwise it's just arm64-apple-ios.

Triplet is a loosely defined historical term that compilers use for this. https://wiki.osdev.org/Target_Triplet

The standard form is "architecture-vendor-os" but for simulator builds, Apple uses ios-simulator for the OS bit. Target triplets in general are a massive mess with tons of historical baggage and lots of exceptions. I mean the more accurate architecture name is aarch64 not arm64, but Apple's gonna Apple.

flutter/flutter@0b9f928...9a78af5 2025-05-15 bkonyi@google.com Manual pub package roll (flutter/flutter#168916) 2025-05-15 matanlurey@users.noreply.github.com Remove unnecessary `bringup: true` for release-channel only `Linux flutter_packaging`. (flutter/flutter#168761) 2025-05-15 matanlurey@users.noreply.github.com Revert: "Run `flutter_packaging` builders on release candidates (flutter/flutter#168917) 2025-05-15 engine-flutter-autoroll@skia.org Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (flutter/flutter#168911) 2025-05-15 engine-flutter-autoroll@skia.org Roll Packages from 1468581 to 2dff621 (4 revisions) (flutter/flutter#168908) 2025-05-15 engine-flutter-autoroll@skia.org Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (flutter/flutter#168895) 2025-05-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (flutter/flutter#168893) 2025-05-15 jsimionato@google.com Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (flutter/flutter#168888) 2025-05-15 dacoharkes@google.com [native assets] Remove `KernelSnapshot` dependency in build (flutter/flutter#168742) 2025-05-15 chris@bracken.jp iOS,macOS: Migrate logging to Logger/FlutterLogger (flutter/flutter#168568) 2025-05-15 58529443+srujzs@users.noreply.github.com Skip hot reload breakpoints test when running with web (flutter/flutter#168873) 2025-05-15 victorsanniay@gmail.com CupertinoSliverNavigationBar respects accessibility text scaling (flutter/flutter#168866) 2025-05-15 jonahwilliams@google.com [display_list] paint cleanup. (flutter/flutter#168082) 2025-05-15 jsimionato@google.com Add a new CI build for iOS DDM-enabled artifacts (flutter/flutter#168717) 2025-05-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (flutter/flutter#168880) 2025-05-14 30870216+gaaclarke@users.noreply.github.com Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#168396) 2025-05-14 matanlurey@users.noreply.github.com Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871) 2025-05-14 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be unflaky (flutter/flutter#167634) 2025-05-14 victorsanniay@gmail.com Reland "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions" (flutter/flutter#168772) 2025-05-14 matanlurey@users.noreply.github.com Remove references to `team-release`. (flutter/flutter#168780) 2025-05-14 58190796+MitchellGoodwin@users.noreply.github.com Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion (flutter/flutter#168182) 2025-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use live region in error text input decorator for Android (#165531)" (flutter/flutter#168848) 2025-05-14 huy@nevercode.io Normalize BottomAppBarTheme (flutter/flutter#168586) 2025-05-14 engine-flutter-autoroll@skia.org Roll Packages from 2e166de to 1468581 (2 revisions) (flutter/flutter#168828) 2025-05-14 chris@bracken.jp macOS,iOS: fix swift target triple (flutter/flutter#168749) 2025-05-14 matanlurey@users.noreply.github.com Further update `Engine-artifacts.md`. (flutter/flutter#168779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9259) flutter/flutter@0b9f928...9a78af5 2025-05-15 bkonyi@google.com Manual pub package roll (flutter/flutter#168916) 2025-05-15 matanlurey@users.noreply.github.com Remove unnecessary `bringup: true` for release-channel only `Linux flutter_packaging`. (flutter/flutter#168761) 2025-05-15 matanlurey@users.noreply.github.com Revert: "Run `flutter_packaging` builders on release candidates (flutter/flutter#168917) 2025-05-15 engine-flutter-autoroll@skia.org Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (flutter/flutter#168911) 2025-05-15 engine-flutter-autoroll@skia.org Roll Packages from 1468581 to 2dff621 (4 revisions) (flutter/flutter#168908) 2025-05-15 engine-flutter-autoroll@skia.org Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (flutter/flutter#168895) 2025-05-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (flutter/flutter#168893) 2025-05-15 jsimionato@google.com Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (flutter/flutter#168888) 2025-05-15 dacoharkes@google.com [native assets] Remove `KernelSnapshot` dependency in build (flutter/flutter#168742) 2025-05-15 chris@bracken.jp iOS,macOS: Migrate logging to Logger/FlutterLogger (flutter/flutter#168568) 2025-05-15 58529443+srujzs@users.noreply.github.com Skip hot reload breakpoints test when running with web (flutter/flutter#168873) 2025-05-15 victorsanniay@gmail.com CupertinoSliverNavigationBar respects accessibility text scaling (flutter/flutter#168866) 2025-05-15 jonahwilliams@google.com [display_list] paint cleanup. (flutter/flutter#168082) 2025-05-15 jsimionato@google.com Add a new CI build for iOS DDM-enabled artifacts (flutter/flutter#168717) 2025-05-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (flutter/flutter#168880) 2025-05-14 30870216+gaaclarke@users.noreply.github.com Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#168396) 2025-05-14 matanlurey@users.noreply.github.com Mark web_tool_tests_1_2 as bringup. (flutter/flutter#168871) 2025-05-14 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be unflaky (flutter/flutter#167634) 2025-05-14 victorsanniay@gmail.com Reland "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions" (flutter/flutter#168772) 2025-05-14 matanlurey@users.noreply.github.com Remove references to `team-release`. (flutter/flutter#168780) 2025-05-14 58190796+MitchellGoodwin@users.noreply.github.com Make Cupertino sheet set the systemUIStyle through an AnnotatedRegion (flutter/flutter#168182) 2025-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use live region in error text input decorator for Android (#165531)" (flutter/flutter#168848) 2025-05-14 huy@nevercode.io Normalize BottomAppBarTheme (flutter/flutter#168586) 2025-05-14 engine-flutter-autoroll@skia.org Roll Packages from 2e166de to 1468581 (2 revisions) (flutter/flutter#168828) 2025-05-14 chris@bracken.jp macOS,iOS: fix swift target triple (flutter/flutter#168749) 2025-05-14 matanlurey@users.noreply.github.com Further update `Engine-artifacts.md`. (flutter/flutter#168779) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the engine flutter/engine related. See also e: labels. label May 13, 2025

cbracken requested review from loic-sharma and vashworth May 13, 2025 17:55

cbracken force-pushed the fix-deployment-target branch from 9f1e924 to 6e94201 Compare May 13, 2025 18:01

hellohuanlin approved these changes May 13, 2025

View reviewed changes

loic-sharma approved these changes May 13, 2025

View reviewed changes

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2025

cbracken added this pull request to the merge queue May 14, 2025

Merged via the queue into flutter:master with commit 8e35392 May 14, 2025
178 of 180 checks passed

cbracken deleted the fix-deployment-target branch May 14, 2025 16:27

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

cd49899

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 1d8078552d99 (21 revisions) flutter/packages#9253

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

beae92f

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to d69edc303b49 (22 revisions) flutter/packages#9255

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

b1e7509

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to a164f6538603 (23 revisions) flutter/packages#9256

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

4311b65

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 94c661082cc3 (24 revisions) flutter/packages#9257

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

2786ccb

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9214ed12dbae (25 revisions) flutter/packages#9258

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

48b67e7

engine-flutter-autoroll mentioned this pull request May 15, 2025

Roll Flutter from 0b9f9288caf3 to 9a78af5eb067 (26 revisions) flutter/packages#9259

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

aa46c57

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

9e9b40a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

45cb63c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

275cefc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

8e3539287 macOS,iOS: fix swift target triple (flutter/flutter#168749)

d35f3d0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

macOS,iOS: fix swift target triple #168749

macOS,iOS: fix swift target triple #168749

Uh oh!

cbracken commented May 13, 2025 •

edited

Loading

Uh oh!

hellohuanlin May 13, 2025

Uh oh!

cbracken May 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

macOS,iOS: fix swift target triple #168749

macOS,iOS: fix swift target triple #168749

Uh oh!

Conversation

cbracken commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

hellohuanlin May 13, 2025

Choose a reason for hiding this comment

Uh oh!

cbracken May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cbracken commented May 13, 2025 •

edited

Loading

cbracken May 13, 2025 •

edited

Loading