Skip to content

Make MergeSemantics be able to merge customAction #168414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2025
Merged

Make MergeSemantics be able to merge customAction #168414

merged 4 commits into from
May 8, 2025

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented May 6, 2025 •
edited
Loading

Fixes #166588

When merging semantics, an empty customSemanticsActions was always used instead of using the _customSemanticsActions of the current semantics node.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels May 6, 2025
@QuncCccccc QuncCccccc requested a review from chunhtai May 6, 2025 20:47
chunhtai
chunhtai reviewed May 6, 2025
View reviewed changes
packages/flutter/test/widgets/semantics_test.dart
MergeSemantics(
child: Column(
children: <Widget>[
Semantics(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To properly test this , they have to create their own node, so I think we need container:true for both semantics widget

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks! Just updated!

@QuncCccccc QuncCccccc requested a review from chunhtai May 7, 2025 16:48
chunhtai
chunhtai approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 8, 2025
Merged via the queue into flutter:master with commit 194fb17 May 8, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
194fb17d2 Make MergeSemantics be able to merge customAction (flutter/…
45c479a 
…flutter#168414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
194fb17d2 Make MergeSemantics be able to merge customAction (flutter/…
fc81765 
…flutter#168414)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
194fb17d2 Make MergeSemantics be able to merge customAction (flutter/…
6ce5667 
…flutter#168414)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
Roll Flutter from b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) (#9230)
b270eae 
flutter/flutter@b0f5c8c...02d8c1a

2025-05-08 chris@bracken.jp iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517)
2025-05-08 engine-flutter-autoroll@skia.org Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548)
2025-05-08 zhongliu88889@gmail.com Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526)
2025-05-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525)
2025-05-08 36861262+QuncCccccc@users.noreply.github.com Make MergeSemantics be able to merge customAction (flutter/flutter#168414)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514)
2025-05-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#168509)
2025-05-07 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114)
2025-05-07 20605958+mohamedamara@users.noreply.github.com Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505)
2025-05-07 kevmoo@users.noreply.github.com [web] drop more use of deprecated JS functions (flutter/flutter#166157)
2025-05-07 83038251+nailahsall0@users.noreply.github.com docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489)
2025-05-07 matanlurey@users.noreply.github.com Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433)
2025-05-07 sokolovskyi.konstantin@gmail.com Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479)
2025-05-07 robert.ancell@canonical.com Fix stencil buffer leak (flutter/flutter#168448)
2025-05-07 robert.ancell@canonical.com Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447)
2025-05-07 robert.ancell@canonical.com Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 9, 2025
Open
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) (flutte…
1cc9399 
…r#9230)

flutter/flutter@b0f5c8c...02d8c1a

2025-05-08 chris@bracken.jp iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517)
2025-05-08 engine-flutter-autoroll@skia.org Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548)
2025-05-08 zhongliu88889@gmail.com Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526)
2025-05-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525)
2025-05-08 36861262+QuncCccccc@users.noreply.github.com Make MergeSemantics be able to merge customAction (flutter/flutter#168414)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514)
2025-05-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#168509)
2025-05-07 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114)
2025-05-07 20605958+mohamedamara@users.noreply.github.com Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505)
2025-05-07 kevmoo@users.noreply.github.com [web] drop more use of deprecated JS functions (flutter/flutter#166157)
2025-05-07 83038251+nailahsall0@users.noreply.github.com docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489)
2025-05-07 matanlurey@users.noreply.github.com Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433)
2025-05-07 sokolovskyi.konstantin@gmail.com Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479)
2025-05-07 robert.ancell@canonical.com Fix stencil buffer leak (flutter/flutter#168448)
2025-05-07 robert.ancell@canonical.com Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447)
2025-05-07 robert.ancell@canonical.com Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) (flutte…
25ae343 
…r#9230)

flutter/flutter@b0f5c8c...02d8c1a

2025-05-08 chris@bracken.jp iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517)
2025-05-08 engine-flutter-autoroll@skia.org Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548)
2025-05-08 zhongliu88889@gmail.com Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526)
2025-05-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525)
2025-05-08 36861262+QuncCccccc@users.noreply.github.com Make MergeSemantics be able to merge customAction (flutter/flutter#168414)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514)
2025-05-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#168509)
2025-05-07 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114)
2025-05-07 20605958+mohamedamara@users.noreply.github.com Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505)
2025-05-07 kevmoo@users.noreply.github.com [web] drop more use of deprecated JS functions (flutter/flutter#166157)
2025-05-07 83038251+nailahsall0@users.noreply.github.com docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489)
2025-05-07 matanlurey@users.noreply.github.com Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433)
2025-05-07 sokolovskyi.konstantin@gmail.com Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479)
2025-05-07 robert.ancell@canonical.com Fix stencil buffer leak (flutter/flutter#168448)
2025-05-07 robert.ancell@canonical.com Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447)
2025-05-07 robert.ancell@canonical.com Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
194fb17d2 Make MergeSemantics be able to merge customAction (flutter/…
516b7ec 
…flutter#168414)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
194fb17d2 Make MergeSemantics be able to merge customAction (flutter/…
dca6aa2 
…flutter#168414)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
194fb17d2 Make MergeSemantics be able to merge customAction (flutter/…
f4827ba 
…flutter#168414)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
194fb17d2 Make MergeSemantics be able to merge customAction (flutter/…
cd1069d 
…flutter#168414)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
194fb17d2 Make MergeSemantics be able to merge customAction (flutter/…
66e9699 
…flutter#168414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MergeSemantics does not merge custom actions
2 participants
@QuncCccccc @chunhtai