Skip to content

feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. #166820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 6, 2025
Merged

feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. #166820

merged 12 commits into from
May 6, 2025

Conversation

StanleyCocos
Copy link
Contributor

@StanleyCocos StanleyCocos commented Apr 9, 2025 •
edited
Loading

This PR is a continuation of 165481

Related items also include: RadioListTile, CheckboxListTile

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 9, 2025
@StanleyCocos StanleyCocos marked this pull request as ready for review April 9, 2025 11:54
@StanleyCocos StanleyCocos marked this pull request as draft April 9, 2025 11:54
@StanleyCocos StanleyCocos marked this pull request as ready for review April 10, 2025 06:31
This was referenced Apr 18, 2025
Merged
Merged
@StanleyCocos
Copy link
Contributor Author

@dkwingsmt
Sorry to bother you. I noticed that this request doesn’t seem to have been triaged. Could you help assign someone to review this request?

@dkwingsmt dkwingsmt self-requested a review April 21, 2025 17:58
@dkwingsmt dkwingsmt added team-design Owned by Design Languages team and removed team-design Owned by Design Languages team labels Apr 21, 2025
dkwingsmt
dkwingsmt approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

justinmc
justinmc approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the same nits as in #166964 (review) (line length and unnecessary key).

@StanleyCocos
Copy link
Contributor Author

LGTM with the same nits as in #166964 (review) (line length and unnecessary key).

Thank you.
I have already updated or explained my intention.

github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2025
@StanleyCocos
feat(CheckboxListTile): ensure that 'isThreeLine' can be configured t…
adae8bb 
…hrough the theme. (#166826)

This PR is a continuation of
[165481](#165481)

Related items also include:
[SwitchListTile](#166820),
[RadioListTile](#166964)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@dkwingsmt
Copy link
Contributor

All 3 PRs are good to land, but we'll have to resolve the conflict for each one. :) Let me know when you resolve a 2nd PR and let's land it.

@StanleyCocos
Copy link
Contributor Author

Yes, they have to be merged one by one. I’ve already resolved the second one. Once the second is done, I’ll move on to the third. Thank you!

github-merge-queue bot pushed a commit that referenced this pull request May 6, 2025
@StanleyCocos @dkwingsmt
feat(RadioListTile):ensure that 'isThreeLine' can be configured throu…
dfd0a3c 
…gh the (#166964)

This PR is a continuation of
[165481](#165481)

Related items also include:
[SwitchListTile](#166820),
[CheckboxListTile](#166826)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
@StanleyCocos
Merge branch 'master' into feature/switch_list_tile
559ac81 
# Conflicts:
#	packages/flutter/lib/src/material/list_tile_theme.dart
#	packages/flutter/test/material/switch_list_tile_test.dart
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
2132238 
…igured through the theme. (flutter/flutter#166820)
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@StanleyCocos @dkwingsmt @mboetger
feat(RadioListTile):ensure that 'isThreeLine' can be configured throu…
0076160 
…gh the (flutter#166964)

This PR is a continuation of
[165481](flutter#165481)

Related items also include:
[SwitchListTile](flutter#166820),
[CheckboxListTile](flutter#166826)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@StanleyCocos @mboetger
feat(SwitchListTile): ensure that 'isThreeLine' can be configured thr…
6d3aa69 
…ough the theme. (flutter#166820)

This PR is a continuation of
[165481](flutter#165481)

Related items also include:
[RadioListTile](flutter#166964),
[CheckboxListTile](flutter#166826)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
26008c4 
…igured through the theme. (flutter/flutter#166820)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
93cc341 
…igured through the theme. (flutter/flutter#166820)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
f5dbd79 
…igured through the theme. (flutter/flutter#166820)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
3f93439 
…igured through the theme. (flutter/flutter#166820)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
710a537 
…igured through the theme. (flutter/flutter#166820)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
6ed64c6 
…igured through the theme. (flutter/flutter#166820)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
fd2c8db 
…igured through the theme. (flutter/flutter#166820)
@StanleyCocos StanleyCocos deleted the feature/switch_list_tile branch May 8, 2025 01:45
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (#9223)
1392e8c 
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 34465683+rkishan516@users.noreply.github.com Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 engine-flutter-autoroll@skia.org Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 15619084+vashworth@users.noreply.github.com Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 chris@bracken.jp macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 chris@bracken.jp iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 jason-simmons@users.noreply.github.com Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 markzipan@google.com Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 jmccandless@google.com Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 jacksongardner@google.com [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 chinmaygarde@google.com [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 sokolovskyi.konstantin@gmail.com Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 engine-flutter-autoroll@skia.org Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 matanlurey@users.noreply.github.com Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 15619084+vashworth@users.noreply.github.com Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 stanleycocoa@gmail.com feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 kevmoo@users.noreply.github.com [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 codefu@google.com Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 stanleycocoa@gmail.com feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 36861262+QuncCccccc@users.noreply.github.com Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 jessiewong401@gmail.com Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 chris@bracken.jp macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 jason-simmons@users.noreply.github.com Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 markzipan@google.com Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 engine-flutter-autoroll@skia.org Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 jason-simmons@users.noreply.github.com Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 21270878+elliette@users.noreply.github.com [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 markzipan@google.com Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 1063596+reidbaker@users.noreply.github.com Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 jacksongardner@google.com Skwasm heavy (flutter/flutter#166619)
2025-05-05 jason-simmons@users.noreply.github.com Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 52936414+CoderNamedHendrick@users.noreply.github.com Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 34871572+gmackall@users.noreply.github.com Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 flar@google.com [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
@Piinks Piinks mentioned this pull request May 9, 2025
Open
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
cf1d157 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 34465683+rkishan516@users.noreply.github.com Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 engine-flutter-autoroll@skia.org Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 15619084+vashworth@users.noreply.github.com Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 chris@bracken.jp macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 chris@bracken.jp iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 jason-simmons@users.noreply.github.com Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 markzipan@google.com Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 jmccandless@google.com Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 jacksongardner@google.com [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 chinmaygarde@google.com [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 sokolovskyi.konstantin@gmail.com Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 engine-flutter-autoroll@skia.org Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 matanlurey@users.noreply.github.com Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 15619084+vashworth@users.noreply.github.com Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 stanleycocoa@gmail.com feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 kevmoo@users.noreply.github.com [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 codefu@google.com Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 stanleycocoa@gmail.com feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 36861262+QuncCccccc@users.noreply.github.com Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 jessiewong401@gmail.com Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 chris@bracken.jp macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 jason-simmons@users.noreply.github.com Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 markzipan@google.com Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 engine-flutter-autoroll@skia.org Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 jason-simmons@users.noreply.github.com Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 21270878+elliette@users.noreply.github.com [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 markzipan@google.com Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 1063596+reidbaker@users.noreply.github.com Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 jacksongardner@google.com Skwasm heavy (flutter/flutter#166619)
2025-05-05 jason-simmons@users.noreply.github.com Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 52936414+CoderNamedHendrick@users.noreply.github.com Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 34871572+gmackall@users.noreply.github.com Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 flar@google.com [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
aed46c7 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 34465683+rkishan516@users.noreply.github.com Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 engine-flutter-autoroll@skia.org Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 15619084+vashworth@users.noreply.github.com Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 chris@bracken.jp macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 chris@bracken.jp iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 jason-simmons@users.noreply.github.com Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 markzipan@google.com Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 jmccandless@google.com Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 jacksongardner@google.com [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 chinmaygarde@google.com [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 sokolovskyi.konstantin@gmail.com Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 engine-flutter-autoroll@skia.org Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 matanlurey@users.noreply.github.com Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 15619084+vashworth@users.noreply.github.com Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 stanleycocoa@gmail.com feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 kevmoo@users.noreply.github.com [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 codefu@google.com Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 stanleycocoa@gmail.com feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 36861262+QuncCccccc@users.noreply.github.com Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 jessiewong401@gmail.com Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 chris@bracken.jp macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 jason-simmons@users.noreply.github.com Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 markzipan@google.com Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 engine-flutter-autoroll@skia.org Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 jason-simmons@users.noreply.github.com Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 21270878+elliette@users.noreply.github.com [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 markzipan@google.com Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 1063596+reidbaker@users.noreply.github.com Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 jacksongardner@google.com Skwasm heavy (flutter/flutter#166619)
2025-05-05 jason-simmons@users.noreply.github.com Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 52936414+CoderNamedHendrick@users.noreply.github.com Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 34871572+gmackall@users.noreply.github.com Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 flar@google.com [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
c32f7c3 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 34465683+rkishan516@users.noreply.github.com Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 engine-flutter-autoroll@skia.org Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 15619084+vashworth@users.noreply.github.com Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 chris@bracken.jp macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 chris@bracken.jp iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 jason-simmons@users.noreply.github.com Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 markzipan@google.com Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 jmccandless@google.com Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 jacksongardner@google.com [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 chinmaygarde@google.com [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 sokolovskyi.konstantin@gmail.com Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 engine-flutter-autoroll@skia.org Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 matanlurey@users.noreply.github.com Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 15619084+vashworth@users.noreply.github.com Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 stanleycocoa@gmail.com feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 kevmoo@users.noreply.github.com [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 codefu@google.com Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 stanleycocoa@gmail.com feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 36861262+QuncCccccc@users.noreply.github.com Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 jessiewong401@gmail.com Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 chris@bracken.jp macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 jason-simmons@users.noreply.github.com Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 markzipan@google.com Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 engine-flutter-autoroll@skia.org Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 jason-simmons@users.noreply.github.com Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 21270878+elliette@users.noreply.github.com [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 markzipan@google.com Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 1063596+reidbaker@users.noreply.github.com Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 jacksongardner@google.com Skwasm heavy (flutter/flutter#166619)
2025-05-05 jason-simmons@users.noreply.github.com Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 52936414+CoderNamedHendrick@users.noreply.github.com Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 34871572+gmackall@users.noreply.github.com Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 flar@google.com [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
902c41e 
…igured through the theme. (flutter/flutter#166820)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
43a9664 
…igured through the theme. (flutter/flutter#166820)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@StanleyCocos @romanejaquez
feat(CheckboxListTile): ensure that 'isThreeLine' can be configured t…
f12c629 
…hrough the theme. (flutter#166826)

This PR is a continuation of
[165481](flutter#165481)

Related items also include:
[SwitchListTile](flutter#166820),
[RadioListTile](flutter#166964)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
58079ef 
…igured through the theme. (flutter/flutter#166820)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
a0d3941 
…igured through the theme. (flutter/flutter#166820)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
c02d22d8a feat(SwitchListTile): ensure that 'isThreeLine' can be conf…
d8adbf5 
…igured through the theme. (flutter/flutter#166820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanleyCocos @dkwingsmt @justinmc