Skip to content

[web] reland fix text selection offset in multi-line fields #166714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

[web] reland fix text selection offset in multi-line fields #166714

merged 2 commits into from
Apr 7, 2025

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Apr 7, 2025

Fixes #162698

This reland contains the original changes from #166565, plus Safari-specific test fixes.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Apr 7, 2025
@yjbanov yjbanov force-pushed the i162698-drag-to-select-attempt-2 branch from 9aa615e to 4359fdc Compare April 7, 2025 20:51
@yjbanov yjbanov requested review from justinmc and loic-sharma April 7, 2025 20:51
justinmc
justinmc approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM 👍

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Apr 7, 2025

autosubmit label was removed for flutter/flutter/166714, because - The status or check suite Linux linux_fuchsia_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 7, 2025
Merged via the queue into flutter:master with commit 0a29c6d Apr 7, 2025
174 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
e4faefe 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
d3f3b2e 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
a434102 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
9a838af 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
2524bd6 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
0fafb0c 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
67b2d66 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
61d70a4 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
afcb7c3 
…lutter/flutter#166714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
318ef18 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
1e6efa7 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
0ae47aa 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
d7c0e05 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
154dc3c 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
a28c68a 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
a242ca6 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
b4cdf08 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
c651a36 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
1fce11f 
…lutter/flutter#166714)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (#9041)
5faf596 
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll @nick-llewellyn
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
a7e131c 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
@Frogperson Frogperson mentioned this pull request Apr 24, 2025
Closed
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions) …
8f5e6a5 
…(#9041)

Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
9e76dc9 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
8146818 
…lutter/flutter#166714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
0a29c6d [web] reland fix text selection offset in multi-line fields (f…
7cfe8f7 
…lutter/flutter#166714)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
e8d24f5 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@yjbanov
[web] reland fix text selection offset in multi-line fields (flutter#…
dc03a08 
…166714)

Fixes flutter#162698

This reland contains the original changes from
flutter#166565, plus Safari-specific
test fixes.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
ad840f8 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
aae1da3 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@yjbanov @romanejaquez
[web] reland fix text selection offset in multi-line fields (flutter#…
963d5a6 
…166714)

Fixes flutter#162698

This reland contains the original changes from
flutter#166565, plus Safari-specific
test fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Click-and-drag to select text in TextField is offset until ending gesture
3 participants
@yjbanov @justinmc @loic-sharma