Skip to content

Reverts "[web] fix text selection offset in multi-line fields (#166565)" #166644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Reverts "[web] fix text selection offset in multi-line fields (#166565)" #166644

merged 1 commit into from
Apr 5, 2025

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Apr 5, 2025

Reverts: #166565

Initiated by: jtmcdole

Reason for reverting: Tree is broken https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/1240/overview

Original PR Author: yjbanov

Reviewed By: {justinmc}

This change reverts the following previous change:
Fixes #162698

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 5, 2025
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Apr 5, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 5, 2025
Merged via the queue into master with commit 778ed9e Apr 5, 2025
8 of 11 checks passed
@auto-submit auto-submit bot deleted the revert_a56ff4890d9d09c3d6d8759f6fcfe8b374af07ba branch April 5, 2025 17:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
5d176a8 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
9d5e0b6 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
f04584c 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
6d09eab 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
69c6f31 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
b3bbf54 
… (#166565)" (flutter/flutter#166644)
This was referenced Apr 7, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
7efb053 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
52799de 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
d4c64d0 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
0de3f47 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
7e53b72 
… (#166565)" (flutter/flutter#166644)
This was referenced Apr 8, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
8f8212b 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
e090516 
… (#166565)" (flutter/flutter#166644)
This was referenced Apr 8, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
741d8f0 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
206c17e 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
99dbe10 
… (#166565)" (flutter/flutter#166644)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
6d2b819 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
bce8426 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
2719bbc 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
14b6f91 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
722aa63 
… (#166565)" (flutter/flutter#166644)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (#9036)
431dc61 
Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll @nick-llewellyn
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
26190fa 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 02f13c37841f to 212064a3e558 (21 revisions) …
b2c45f9 
…(#9036)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 95f8e65 to 57f42e1 (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
a64fe2b 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
cd9d40a 
… (#166565)" (flutter/flutter#166644)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
778ed9e Reverts "[web] fix text selection offset in multi-line fields…
33c6aeb 
… (#166565)" (flutter/flutter#166644)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
772704a 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@auto-submit
Reverts "[web] fix text selection offset in multi-line fields (flutte…
5d7ad68 
…r#166565)" (flutter#166644)

<!-- start_original_pr_link -->
Reverts: flutter#166565
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Tree is broken
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/1240/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: yjbanov
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes flutter#162698
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
a222ab8 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
c3facb2 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@auto-submit @romanejaquez
Reverts "[web] fix text selection offset in multi-line fields (flutte…
ea5c0aa 
…r#166565)" (flutter#166644)

<!-- start_original_pr_link -->
Reverts: flutter#166565
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Tree is broken
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/1240/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: yjbanov
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes flutter#162698
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@jtmcdole jtmcdole

Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Click-and-drag to select text in TextField is offset until ending gesture
2 participants
@fluttergithubbot @jtmcdole