Skip to content

[web] fix text selection offset in multi-line fields #166565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2025
Merged

[web] fix text selection offset in multi-line fields #166565

merged 4 commits into from
Apr 4, 2025

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Apr 4, 2025

Fixes #162698

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Apr 4, 2025
@yjbanov yjbanov marked this pull request as ready for review April 4, 2025 00:12
@github-actions github-actions bot added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Apr 4, 2025
@yjbanov yjbanov mentioned this pull request Apr 4, 2025
Closed
loic-sharma
loic-sharma reviewed Apr 4, 2025
View reviewed changes
engine/src/flutter/lib/web_ui/lib/src/engine/text_editing/input_type.dart Outdated

DomHTMLTextAreaElement createMultilineTextArea() {
final element = createDomHTMLTextAreaElement();
// Scrollbar width affects text layout. This zeros out the scrollbar width.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most pedantic nit in the world, I'm sorry: 😂

Suggested change
// Scrollbar width affects text layout. This zeros out the scrollbar width.
// Scrollbar width affects text layout. This zeroes out the scrollbar width.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

justinmc
justinmc approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

So the text in the underlying HTML input was not in the same position as Flutter's text because the HTML input had scrollbars and was aligned differently? Makes sense assuming this fixes the bug in the issue.

I guess it's not possible to write a test that reproduces the actual bug in the issue since the problem was with the engine.

The Google test failures seem to be an infrastructure problem of some sort.

engine/src/flutter/lib/web_ui/test/engine/text_editing_test.dart

final submitElement = formElement.children.last;
expect(submitElement.style.alignContent, isEmpty);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this use of blocks to isolate variables, I might start doing this in tests...

@yjbanov
Copy link
Contributor Author

yjbanov commented Apr 4, 2025

So the text in the underlying HTML input was not in the same position as Flutter's text because the HTML input had scrollbars and was aligned differently? Makes sense assuming this fixes the bug in the issue.

It fixes the issue in my local testing. However, if you ask why it fixes it, I don't have a good explanation. My best guess is that the misalignment of the start of the text (top-left corner in LTR, and top-right in RTL) confuses the browser about start-end selection regions vs pointer events.

I guess it's not possible to write a test that reproduces the actual bug in the issue since the problem was with the engine.

The challenge is that we're not able to dispatch pointer events in a way that would reproduce text selection in a way it happens in reality. There's some gnarly interaction between Flutter's EditableText and the underlying <input> element. I'm not aware of a way to synthesize events that would interact the same way.

The Google test failures seem to be an infrastructure problem of some sort.

Yeah, I'm guessing we still don't know how to test engine code changes in the monorepo world.

@yjbanov yjbanov force-pushed the i162698-drag-to-select branch from 4c9db3f to bee63c8 Compare April 4, 2025 17:51
@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Apr 4, 2025

autosubmit label was removed for flutter/flutter/166565, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2025
@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 4, 2025
Merged via the queue into flutter:master with commit a56ff48 Apr 4, 2025
171 of 172 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2025
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Apr 5, 2025
@jason-simmons
[web] Fixes for some text editing tests on Safari
533e9f5 
* Add a setSizeAndTransform call which is required to position the input element on Safari
* Disable a test that uses CSS scrollbar-width, which is not supported by the Safari version on the bots

See flutter#166565
@jason-simmons jason-simmons mentioned this pull request Apr 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
fd22208 
…/flutter#166565)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2025
Closed
@jtmcdole
Copy link
Member

jtmcdole commented Apr 5, 2025

Reason for revert: Tree is broken https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/1240/overview

@jtmcdole jtmcdole added the revert Autorevert PR (with "Reason for revert:" comment) label Apr 5, 2025
auto-submit bot pushed a commit that referenced this pull request Apr 5, 2025
Revert "[web] fix text selection offset in multi-line fields (#166565)"
b2401fd 
This reverts commit a56ff48.
@auto-submit auto-submit bot mentioned this pull request Apr 5, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
97f3f9f 
…/flutter#166565)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
9fb6797 
…/flutter#166565)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
862c6d1 
…/flutter#166565)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
e0905ed 
…/flutter#166565)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
8a21fd2 
…/flutter#166565)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
8885fcd 
…/flutter#166565)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
b21922c 
…/flutter#166565)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
c59b1d0 
…/flutter#166565)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
32ffaf7 
…/flutter#166565)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
f10d9a2 
…/flutter#166565)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (#9036)
431dc61 
Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request Apr 18, 2025
Open
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll @nick-llewellyn
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
26190fa 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 02f13c37841f to 212064a3e558 (21 revisions) …
b2c45f9 
…(#9036)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 95f8e65 to 57f42e1 (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
513a1ef 
…/flutter#166565)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
6db02ab 
…/flutter#166565)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a56ff48 [web] fix text selection offset in multi-line fields (flutter…
a145c95 
…/flutter#166565)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
772704a 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@yjbanov
[web] fix text selection offset in multi-line fields (flutter#166565)
2c1f051 
Fixes flutter#162698
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@auto-submit
Reverts "[web] fix text selection offset in multi-line fields (flutte…
5d7ad68 
…r#166565)" (flutter#166644)

<!-- start_original_pr_link -->
Reverts: flutter#166565
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Tree is broken
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/1240/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: yjbanov
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes flutter#162698
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@yjbanov
[web] reland fix text selection offset in multi-line fields (flutter#…
dc03a08 
…166714)

Fixes flutter#162698

This reland contains the original changes from
flutter#166565, plus Safari-specific
test fixes.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
a222ab8 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
c3facb2 
)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@02f13c3...212064a

2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925)
2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496)
2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@yjbanov @romanejaquez
[web] fix text selection offset in multi-line fields (flutter#166565)
0405bc5 
Fixes flutter#162698
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@auto-submit @romanejaquez
Reverts "[web] fix text selection offset in multi-line fields (flutte…
ea5c0aa 
…r#166565)" (flutter#166644)

<!-- start_original_pr_link -->
Reverts: flutter#166565
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Tree is broken
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/1240/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: yjbanov
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes flutter#162698
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@yjbanov @romanejaquez
[web] reland fix text selection offset in multi-line fields (flutter#…
963d5a6 
…166714)

Fixes flutter#162698

This reland contains the original changes from
flutter#166565, plus Safari-specific
test fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma left review comments

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Click-and-drag to select text in TextField is offset until ending gesture
4 participants
@yjbanov @jtmcdole @justinmc @loic-sharma