[CP-beta] Fix out of band breakages on presubmit #166438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…65675) This test was not running previously on the Linux builder, but it started running again when ASAN was disabled due to the Ubuntu 24 upgrade on LUCI. The test is not currently functioning as intended and needs to be disabled until the Ubuntu upgrade is stable. See flutter#165661
|
@reidbaker please fill out the PR description above, afterwards the release team will review this request. |
jason-simmons
approved these changes
Apr 2, 2025
matanlurey
approved these changes
Apr 2, 2025
|
autosubmit label was removed for flutter/flutter/166438, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/166438, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This is causing issues on LUCI workers that were upgraded to a new version of Ubuntu. See flutter#165594 See flutter#165620
With the ubuntu upgrade, everything is leaking now.
Most of our tests that need graphics already skip Firefox. This test somehow was lucky enough to pass in Firefox until the latest Ubuntu upgrade. It is finally failing as expected, so skipping. Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
|
Current status is I am waiting on #166559 to land in master so that it can also be cherry picked. |
jason-simmons
approved these changes
Apr 4, 2025
jtmcdole
approved these changes
Apr 4, 2025
656a1d9
into
flutter:flutter-3.31-candidate.0
159 checks passed
9 tasks
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
Similar to flutter#166438 Fixes flutter#66553 Cherry pick the following prs to hopefully fix pre/post submits against 3.29. * flutter#165692 * flutter#165675 * flutter#165678 * flutter#166559 * Does not include flutter#165818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by [automatic cherry pick workflow]
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#166553
CP of
Test configuration error
https://mail.google.com/chat/u/0/#chat/space/AAAAQFWU2Go/dHeIlEXFg2w/dHeIlEXFg2w
Changelog Description:
N/A
Impact Description:
blocking #165430
Workaround:
none
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?