Skip to content

Add RoundedSuperellipseBorder and apply it to CupertinoActionSheet #166303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 8, 2025
Merged

Add RoundedSuperellipseBorder and apply it to CupertinoActionSheet #166303

merged 7 commits into from
Apr 8, 2025

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Apr 1, 2025 •
edited
Loading

This PR creates a new class RoundedSuperellipseBorder, which is the main way to draw a rounded superellipse with filling and/or stroking.

The new class is very similar to RoundedRectangleBorder and shares a lot of private code, therefore they reside in the same file.

For demonstration purposes, the rounded superellipse is also applied to CupertinoActionSheet, whose cancel button was drawn with the border class.

Screen.Recording.2025-04-02.at.6.24.33.PM.mov

(Sadly this demo wouldn't fit for dartpad because rounded superellipses are not yet supported on Web.)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository platform-web Web applications specifically e: impeller Impeller rendering backend issues and features requests and removed platform-web Web applications specifically e: impeller Impeller rendering backend issues and features requests labels Apr 1, 2025
@dkwingsmt dkwingsmt marked this pull request as ready for review April 3, 2025 23:05
MitchellGoodwin
MitchellGoodwin approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Assuming the G3 tests can be made to pass. I assume it just didn't pick up on the addRSuperelipse method that was added by the earlier PR yet.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166303 at sha 6fca22e

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 3, 2025
@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166303 at sha ab42cb0

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166303 at sha 94e8c9c

@github-actions github-actions bot removed the engine flutter/engine related. See also e: labels. label Apr 7, 2025
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 8, 2025
Merged via the queue into flutter:master with commit 5e42c80 Apr 8, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@dkwingsmt dkwingsmt deleted the rse-border branch April 8, 2025 00:56
@dkwingsmt dkwingsmt mentioned this pull request Apr 8, 2025
Closed
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
ad2cfb0 
…ionSheet` (flutter/flutter#166303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
4a8a510 
…ionSheet` (flutter/flutter#166303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
dc0901d 
…ionSheet` (flutter/flutter#166303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
9e48656 
…ionSheet` (flutter/flutter#166303)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
fd57b54 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
b823e05 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
f6a34a4 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
991d102 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
23b5de5 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
3de530b 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
0afb431 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
8cebf1a 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
f10f9a4 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
207aca5 
…ionSheet` (flutter/flutter#166303)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (#9041)
5faf596 
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
@Piinks Piinks mentioned this pull request Apr 18, 2025
Open
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll @nick-llewellyn
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
a7e131c 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions) …
8f5e6a5 
…(#9041)

Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
0f1176c 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
648c51d 
…ionSheet` (flutter/flutter#166303)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5e42c80 Add RoundedSuperellipseBorder and apply it to `CupertinoAct…
e12876f 
…ionSheet` (flutter/flutter#166303)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
e8d24f5 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@dkwingsmt
Add RoundedSuperellipseBorder and apply it to CupertinoActionSheet (
302719b 
flutter#166303)

This PR creates a new class `RoundedSuperellipseBorder`, which is the
main way to draw a rounded superellipse with filling and/or stroking.

The new class is very similar to `RoundedRectangleBorder` and shares a
lot of private code, therefore they reside in the same file.

For demonstration purposes, the rounded superellipse is also applied to
`CupertinoActionSheet`, whose cancel button was drawn with the border
class.



https://github.com/user-attachments/assets/39599dcf-5cf1-46e1-ab34-8c477cbef9d4

(Sadly this demo wouldn't fit for dartpad because rounded superellipses
are not yet supported on Web.)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
ad840f8 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
aae1da3 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@dkwingsmt @romanejaquez
Add RoundedSuperellipseBorder and apply it to CupertinoActionSheet (
7bfbd48 
flutter#166303)

This PR creates a new class `RoundedSuperellipseBorder`, which is the
main way to draw a rounded superellipse with filling and/or stroking.

The new class is very similar to `RoundedRectangleBorder` and shares a
lot of private code, therefore they reside in the same file.

For demonstration purposes, the rounded superellipse is also applied to
`CupertinoActionSheet`, whose cancel button was drawn with the border
class.



https://github.com/user-attachments/assets/39599dcf-5cf1-46e1-ab34-8c477cbef9d4

(Sadly this demo wouldn't fit for dartpad because rounded superellipses
are not yet supported on Web.)

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkwingsmt @MitchellGoodwin