-
Notifications
You must be signed in to change notification settings - Fork 29.2k
Cherry pick to fix linux tests #166021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 3 commits into
flutter:flutter-3.29-candidate.0
from
justinmc:cp-d212ca3cb38
Mar 27, 2025
Merged
Cherry pick to fix linux tests #166021
auto-submit
merged 3 commits into
flutter:flutter-3.29-candidate.0
from
justinmc:cp-d212ca3cb38
Mar 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last subshard of Linux tool_integration_test is timing out again: https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20tool_integration_tests_6_6 This increases the subsharding to get the tree to a healthy state <details> <summary> Pre-launch checklist </summary> - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. </details> <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
reidbaker
approved these changes
Mar 27, 2025
@jonahwilliams I'm seeing |
With the ubuntu upgrade, everything is leaking now.
This is causing issues on LUCI workers that were upgraded to a new version of Ubuntu. See flutter#165594 See flutter#165620
That worked, thank you @jason-simmons for the pointer! |
3548963
into
flutter:flutter-3.29-candidate.0
129 checks passed
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks flutter#165430 and flutter#165428. This PR attempts to cherry pick fixes that will make the tests go green. This PR contains cherry-picks of three PRs: * flutter#164935 * flutter#165620 * flutter#165661 Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797. ``` error: { code: 5 message: builder not found: "Linux tool_integration_tests_1_6" } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
engine
flutter/engine related. See also e: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Linux tool_integration_tests*
have been failing on this release branch, blocking cherry picks #165430 and #165428. This PR attempts to cherry pick fixes that will make the tests go green.This PR contains cherry-picks of three PRs:
Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797.