Skip to content

Conversation

justinmc
Copy link
Contributor

@justinmc justinmc commented Mar 26, 2025

The Linux tool_integration_tests* have been failing on this release branch, blocking cherry picks #165430 and #165428. This PR attempts to cherry pick fixes that will make the tests go green.

This PR contains cherry-picks of three PRs:

Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797.

error: {
  code: 5
  message: builder not found: "Linux tool_integration_tests_1_6"
}

The last subshard of Linux tool_integration_test is timing out again:
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20tool_integration_tests_6_6

This increases the subsharding to get the tree to a healthy state


<details>

<summary> Pre-launch checklist </summary> 


- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

</details>


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@justinmc justinmc marked this pull request as ready for review March 26, 2025 21:57
@justinmc justinmc self-assigned this Mar 27, 2025
@justinmc
Copy link
Contributor Author

@jonahwilliams I'm seeing Linux linux_unopt failing with some kind of leak (latest run). Is that related to your PR #165620? Do you have any context on how we can fix it for this branch?

@jason-simmons
Copy link
Member

The memory sanitizers are not currently working on LUCI bots that have been upgraded to Ubuntu 24.

The release branch will need to cherry pick #165620 and #165661

Jonah Williams and others added 2 commits March 27, 2025 15:57
With the ubuntu upgrade, everything is leaking now.
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See flutter#165594
See flutter#165620
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Mar 27, 2025
@justinmc justinmc changed the title Cherry pick Linux_tool_integration_tests* subsharding Cherry pick to fix linux tests Mar 27, 2025
@justinmc
Copy link
Contributor Author

That worked, thank you @jason-simmons for the pointer!

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2025
@auto-submit auto-submit bot merged commit 3548963 into flutter:flutter-3.29-candidate.0 Mar 27, 2025
129 checks passed
@justinmc justinmc deleted the cp-d212ca3cb38 branch March 27, 2025 23:45
@reidbaker reidbaker mentioned this pull request Apr 4, 2025
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks flutter#165430 and flutter#165428. This PR attempts to cherry pick fixes that will make the tests go green.

This PR contains cherry-picks of three PRs:

  * flutter#164935
  * flutter#165620
  * flutter#165661

Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797.

```
error: {
  code: 5
  message: builder not found: "Linux tool_integration_tests_1_6"
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine related. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants