-
Notifications
You must be signed in to change notification settings - Fork 29.2k
Adds semantics input type #165925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds semantics input type #165925
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
@@ -4547,6 +4547,10 @@ class RenderSemanticsAnnotations extends RenderProxyBox { | |||
config.controlsNodes = _properties.controlsNodes; | |||
} | |||
|
|||
if (_properties.inputType != null) { | |||
config.inputType = _properties.inputType!; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should CustomPaint
support this too? Not sure if anyone would use custom-paint for a whole text input though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized we missed a lot property in custom painter as well as our semantics testing framework, let me do that in a different so that we don't introduce too many unrelated change in this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #166374
@@ -2546,6 +2551,7 @@ class _MatchesSemanticsData extends Matcher { | |||
final int? platformViewId; | |||
final int? maxValueLength; | |||
final int? currentValueLength; | |||
final ui.SemanticsInputType? inputType; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's SemanticsInputType.none
, maybe let's avoid null
? Otherwise, the distinction between null
and none
would have cognitive overhead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the matcher, providing null means don't test for the property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual roll requested by stuartmorgan@google.com flutter/flutter@02f13c3...212064a 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925) 2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583) 2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Manual roll requested by stuartmorgan@google.com flutter/flutter@02f13c3...212064a 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925) 2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583) 2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…(#9036) Manual roll requested by stuartmorgan@google.com flutter/flutter@02f13c3...212064a 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925) 2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 95f8e65 to 57f42e1 (2 revisions) (flutter/flutter#166583) 2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Manual roll requested by stuartmorgan@google.com flutter/flutter@02f13c3...212064a 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925) 2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583) 2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> fixes flutter#162130 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
) Manual roll requested by stuartmorgan@google.com flutter/flutter@02f13c3...212064a 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925) 2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583) 2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Manual roll requested by stuartmorgan@google.com flutter/flutter@02f13c3...212064a 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657) 2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647) 2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609) 2025-04-04 47866232+chunhtai@users.noreply.github.com Adds semantics input type (flutter/flutter#165925) 2025-04-04 flar@google.com Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598) 2025-04-04 yjbanov@google.com [web] fix text selection offset in multi-line fields (flutter/flutter#166565) 2025-04-04 jonahwilliams@google.com [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234) 2025-04-04 bkonyi@google.com [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358) 2025-04-04 matej.knopp@gmail.com [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571) 2025-04-04 engine-flutter-autoroll@skia.org Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583) 2025-04-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571) 2025-04-04 jacksongardner@google.com Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559) 2025-04-04 jiahaog@users.noreply.github.com Add x64 ddm variants (flutter/flutter#166511) 2025-04-04 engine-flutter-autoroll@skia.org Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560) 2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551) 2025-04-03 flar@google.com [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305) 2025-04-03 katelovett@google.com Update localizations from console (flutter/flutter#166496) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> fixes flutter#162130 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
fixes #162130
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.