Skip to content

Unset GIT_DIR and other variables before updating #165818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2025
Merged

Unset GIT_DIR and other variables before updating #165818

merged 4 commits into from
Mar 24, 2025

Conversation

jtmcdole
Copy link
Member

update_engine_version.{ps1|sh} needs to operate on a foreign repository.
When flutter is run in a git-hook, these environment variables will override our git calls location and corrupt the install.

fixes: #165390

@jtmcdole jtmcdole requested a review from matanlurey as a code owner March 24, 2025 17:47
jtmcdole added 2 commits March 24, 2025 12:53
@jtmcdole
Unset GIT_DIR and other variables before updating
7255b9b 
update_engine_version.* needs to operate on a foreign repository.
When flutter is run in a git-hook, these environment variables will
override our git calls location and corrupt the install.

fixes: flutter#165390
@jtmcdole
Add tests
40cb359
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Mar 24, 2025

autosubmit label was removed for flutter/flutter/165818, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@jtmcdole jtmcdole added this pull request to the merge queue Mar 24, 2025
@jtmcdole jtmcdole removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
Merged via the queue into flutter:master with commit 2250d39 Mar 24, 2025
145 checks passed
@jtmcdole jtmcdole deleted the fixSubmodule branch March 24, 2025 22:15
@jtmcdole jtmcdole added the cp: beta cherry pick this pull request to beta release candidate branch label Mar 24, 2025
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Mar 24, 2025
@jtmcdole
Unset GIT_DIR and other variables before updating (flutter#165818)
a9503d6 
`update_engine_version.{ps1|sh}` needs to operate on a foreign
repository.
When flutter is run in a git-hook, these environment variables will
override our git calls location and corrupt the install.

fixes: flutter#165390
@hyiso hyiso mentioned this pull request Mar 25, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
46dd100 
…utter#165818)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
ee4d713 
…utter#165818)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
3b31092 
…utter#165818)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
6380480 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
c9a53a7 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
1357448 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
c9b2909 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
322cf75 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
57d9997 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
5f5dbad 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
d02ef5b 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
1900b0d 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
5334f57 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
9ca08c7 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
4215c78 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
35607c1 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
befdb4c 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
b2c2ef2 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
2c3dab9 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
8202458 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
c7503c0 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
38265aa 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
06a17f7 
…utter#165818)
@reidbaker reidbaker mentioned this pull request Apr 4, 2025
Merged
9 tasks
reidbaker pushed a commit to reidbaker/flutter-work that referenced this pull request Apr 4, 2025
@jtmcdole @reidbaker
Unset GIT_DIR and other variables before updating (flutter#165818)
b694378 
`update_engine_version.{ps1|sh}` needs to operate on a foreign
repository.
When flutter is run in a git-hook, these environment variables will
override our git calls location and corrupt the install.

fixes: flutter#165390
jtmcdole added a commit to jtmcdole/flutter that referenced this pull request Apr 8, 2025
@jtmcdole
[CP-Stable] Unset GIT_DIR and other variables before updating
1ebaaba 
Cherry picks flutter#165818

`update_engine_version.{ps1|sh}` needs to operate on a foreign
repository.
When flutter is run in a git-hook, these environment variables will
override our git calls location and corrupt the install.
@jtmcdole jtmcdole mentioned this pull request Apr 8, 2025
Merged
auto-submit bot pushed a commit that referenced this pull request Apr 8, 2025
@reidbaker
Unbreak presubmit for stable (#166594)
915efb1 
Similar to #166438 

Fixes #66553

Cherry pick the following prs to hopefully fix pre/post submits against 3.29. 

* #165692
* #165675
* #165678
* #166559
* Does not include #165818
jtmcdole added a commit to jtmcdole/flutter that referenced this pull request Apr 8, 2025
@jtmcdole
[CP-Stable] Unset GIT_DIR and other variables before updating
9202f9f 
Cherry picks flutter#165818

`update_engine_version.{ps1|sh}` needs to operate on a foreign
repository.
When flutter is run in a git-hook, these environment variables will
override our git calls location and corrupt the install.
auto-submit bot pushed a commit that referenced this pull request Apr 10, 2025
@jtmcdole
[CP-Stable] Unset GIT_DIR and other variables before updating (#166772)
dd7ad71 
Cherry picks #165818

`update_engine_version.{ps1|sh}` needs to operate on a foreign repository.
When flutter is run in a git-hook, these environment variables will override our git calls location and corrupt the install.

Cherry pick notes: The files are diverging a bit; but the guts of the change were clean (ps1|sh) and the tests just needed some care.
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@reidbaker @Fintasys
Unbreak presubmit for stable (flutter#166594)
25c883c 
Similar to flutter#166438

Fixes flutter#66553

Cherry pick the following prs to hopefully fix pre/post submits against 3.29.

* flutter#165692
* flutter#165675
* flutter#165678
* flutter#166559
* Does not include flutter#165818
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@jtmcdole @Fintasys
[CP-Stable] Unset GIT_DIR and other variables before updating (flutte…
0285638 
…r#166772)

Cherry picks flutter#165818

`update_engine_version.{ps1|sh}` needs to operate on a foreign repository.
When flutter is run in a git-hook, these environment variables will override our git calls location and corrupt the install.

Cherry pick notes: The files are diverging a bit; but the guts of the change were clean (ps1|sh) and the tests just needed some care.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
5a2a6d0 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
ade5979 
…utter#165818)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
2250d39 Unset GIT_DIR and other variables before updating (flutter/fl…
8e67ef0 
…utter#165818)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@jtmcdole
Unset GIT_DIR and other variables before updating (flutter#165818)
b67bd94 
`update_engine_version.{ps1|sh}` needs to operate on a foreign
repository.
When flutter is run in a git-hook, these environment variables will
override our git calls location and corrupt the install.

fixes: flutter#165390
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@jtmcdole @romanejaquez
Unset GIT_DIR and other variables before updating (flutter#165818)
52c70d3 
`update_engine_version.{ps1|sh}` needs to operate on a foreign
repository.
When flutter is run in a git-hook, these environment variables will
override our git calls location and corrupt the install.

fixes: flutter#165390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
cp: beta cherry pick this pull request to beta release candidate branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running Flutter CLI in Git Hooks within a Submodule Corrupts Dart SDK
2 participants
@jtmcdole @matanlurey