Skip to content

disable linux lsan. #165620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2025
Merged

disable linux lsan. #165620

merged 2 commits into from
Mar 21, 2025

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 21, 2025 •
edited
Loading

With the ubuntu upgrade, everything is leaking now.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Mar 21, 2025
@jonahwilliams
Copy link
Contributor Author

Should I emergency this one?

@jonahwilliams jonahwilliams added autosubmit Merge PR when tree becomes green via auto submit App emergency Jump the queue; land PR in front of all others; only use for emergencies labels Mar 21, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

1 similar comment
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@auto-submit auto-submit bot added this pull request to the merge queue Mar 21, 2025
Merged via the queue into flutter:master with commit 8b49f4d Mar 21, 2025
168 of 175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2025
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Mar 21, 2025
@jason-simmons
Disable the address sanitizer in the linux_unopt build
0015bdf 
This is causing issues on LUCI workers that were upgraded to a new version of Ubuntu.

See flutter#165594
See flutter#165620
@jason-simmons jason-simmons mentioned this pull request Mar 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 21, 2025
@jason-simmons
Disable the address sanitizer in the linux_unopt build (#165661)
5a8d403 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See #165594
See #165620
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
9847b50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
2b6da94
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
5d0e257
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
a28a543
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
dd80368
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
aa1f83d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
c5870ab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
88602e9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
9307a8e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
ff0f554
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
52a682d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
4d1b000
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
5ef095f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
99fb207
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
531e3e2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
4f8b250
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
1f1ff9c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
62858a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
e0b34af
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
82bcce2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
c1a757a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
bc09e40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
085d46f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
a721050
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
dd2d93c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
d1412d2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
baf428a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
4cb5eaa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
3e962f6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
7c23cd9
reidbaker pushed a commit to flutteractionsbot/flutter that referenced this pull request Apr 2, 2025
@jason-simmons @reidbaker
Disable the address sanitizer in the linux_unopt build (flutter#165661)
f881bdb 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See flutter#165594
See flutter#165620
reidbaker pushed a commit to flutteractionsbot/flutter that referenced this pull request Apr 2, 2025
@reidbaker
disable linux lsan. (flutter#165620)
cda8de9 
With the ubuntu upgrade, everything is leaking now.
@reidbaker reidbaker mentioned this pull request Apr 2, 2025
Merged
5 tasks
auto-submit bot pushed a commit that referenced this pull request Apr 4, 2025
@flutteractionsbot
[CP-beta] Fix out of band breakages on presubmit (#166438)
656a1d9 
This pull request is created by [automatic cherry pick workflow]

### Issue Link:
What is the link to the issue this cherry-pick is addressing?
#166553

CP of 
* #165620
* #165661
* #165675
* #165692 
* #165678
* *Not merged in master* #166559

Test configuration error
https://mail.google.com/chat/u/0/#chat/space/AAAAQFWU2Go/dHeIlEXFg2w/dHeIlEXFg2w

### Changelog Description:
N/A

### Impact Description:
blocking #165430

### Workaround:
none

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@justinmc @Fintasys
Cherry pick to fix linux tests (flutter#166021)
b06705b 
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks flutter#165430 and flutter#165428. This PR attempts to cherry pick fixes that will make the tests go green.

This PR contains cherry-picks of three PRs:

  * flutter#164935
  * flutter#165620
  * flutter#165661

Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797.

```
error: {
  code: 5
  message: builder not found: "Linux tool_integration_tests_1_6"
}
```
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
9f52f10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
69a67bc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
8b49f4d disable linux lsan. (flutter/flutter#165620)
57a4fdd
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
disable linux lsan. (flutter#165620)
b626625 
With the ubuntu upgrade, everything is leaking now.
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@jason-simmons
Disable the address sanitizer in the linux_unopt build (flutter#165661)
b1d09f3 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See flutter#165594
See flutter#165620
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
disable linux lsan. (flutter#165620)
fa8d756 
With the ubuntu upgrade, everything is leaking now.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@jason-simmons @romanejaquez
Disable the address sanitizer in the linux_unopt build (flutter#165661)
c43d856 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See flutter#165594
See flutter#165620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole Awaiting requested review from jtmcdole

Assignees
No one assigned
Labels
emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahwilliams @matanlurey