Skip to content

[web] skip image_to_byte_data_test.dart in Firefox #165678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2025
Merged

[web] skip image_to_byte_data_test.dart in Firefox #165678

merged 3 commits into from
Mar 24, 2025

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Mar 21, 2025

Most of our tests that need graphics already skip Firefox. This test somehow was lucky enough to pass in Firefox until the latest Ubuntu upgrade. It is finally failing as expected, so skipping.

@yjbanov yjbanov requested a review from jtmcdole March 21, 2025 17:47
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Mar 21, 2025
@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Mar 22, 2025

autosubmit label was removed for flutter/flutter/165678, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 22, 2025
@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 24, 2025
Merged via the queue into flutter:master with commit e717b6c Mar 24, 2025
170 of 171 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
6bc67c4 
…lutter#165678)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
2ab7c43 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
4821ea9 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
630299a 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
e1accd0 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
4e498e8 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
130701e 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
d9cd777 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
0af2be5 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
0cd08a5 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
ed90049 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
f05307e 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
76ba580 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
c75eb7a 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
3bd8edd 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
af2a218 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
3864930 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
fefab9d 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
375eded 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
418dbfb 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
b4e3ec0 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
5a4ff9d 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
52780a7 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
662e5bd 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
ee2a773 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
39c9870 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
47f8775 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
8769a05 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
3fe40e9 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
a70d2d7 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
7fa5439 
…lutter#165678)
reidbaker pushed a commit to flutteractionsbot/flutter that referenced this pull request Apr 3, 2025
@yjbanov @kevmoo @reidbaker
[web] skip image_to_byte_data_test.dart in Firefox (flutter#165678)
eadd60d 
Most of our tests that need graphics already skip Firefox. This test
somehow was lucky enough to pass in Firefox until the latest Ubuntu
upgrade. It is finally failing as expected, so skipping.

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
@reidbaker reidbaker mentioned this pull request Apr 3, 2025
Merged
5 tasks
auto-submit bot pushed a commit that referenced this pull request Apr 4, 2025
@flutteractionsbot
[CP-beta] Fix out of band breakages on presubmit (#166438)
656a1d9 
This pull request is created by [automatic cherry pick workflow]

### Issue Link:
What is the link to the issue this cherry-pick is addressing?
#166553

CP of 
* #165620
* #165661
* #165675
* #165692 
* #165678
* *Not merged in master* #166559

Test configuration error
https://mail.google.com/chat/u/0/#chat/space/AAAAQFWU2Go/dHeIlEXFg2w/dHeIlEXFg2w

### Changelog Description:
N/A

### Impact Description:
blocking #165430

### Workaround:
none

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
@reidbaker reidbaker mentioned this pull request Apr 4, 2025
Merged
9 tasks
reidbaker pushed a commit to reidbaker/flutter-work that referenced this pull request Apr 4, 2025
@yjbanov @kevmoo @reidbaker
[web] skip image_to_byte_data_test.dart in Firefox (flutter#165678)
2e03b5d 
Most of our tests that need graphics already skip Firefox. This test
somehow was lucky enough to pass in Firefox until the latest Ubuntu
upgrade. It is finally failing as expected, so skipping.

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
auto-submit bot pushed a commit that referenced this pull request Apr 8, 2025
@reidbaker
Unbreak presubmit for stable (#166594)
915efb1 
Similar to #166438 

Fixes #66553

Cherry pick the following prs to hopefully fix pre/post submits against 3.29. 

* #165692
* #165675
* #165678
* #166559
* Does not include #165818
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@reidbaker @Fintasys
Unbreak presubmit for stable (flutter#166594)
25c883c 
Similar to flutter#166438

Fixes flutter#66553

Cherry pick the following prs to hopefully fix pre/post submits against 3.29.

* flutter#165692
* flutter#165675
* flutter#165678
* flutter#166559
* Does not include flutter#165818
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
af800d2 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
ab8805c 
…lutter#165678)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
e717b6c [web] skip image_to_byte_data_test.dart in Firefox (flutter/f…
48f118a 
…lutter#165678)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@yjbanov @kevmoo
[web] skip image_to_byte_data_test.dart in Firefox (flutter#165678)
e7dbd83 
Most of our tests that need graphics already skip Firefox. This test
somehow was lucky enough to pass in Firefox until the latest Ubuntu
upgrade. It is finally failing as expected, so skipping.

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@yjbanov @kevmoo @romanejaquez
[web] skip image_to_byte_data_test.dart in Firefox (flutter#165678)
97000c0 
Most of our tests that need graphics already skip Firefox. This test
somehow was lucky enough to pass in Firefox until the latest Ubuntu
upgrade. It is finally failing as expected, so skipping.

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees
No one assigned
Labels
engine flutter/engine related. See also e: labels. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjbanov @jtmcdole @kevmoo