fix(ListTileTheme): isThreeLine is missing. #165481

StanleyCocos · 2025-03-19T09:35:33Z

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

StanleyCocos · 2025-03-21T03:41:17Z

I know that SwitchListTile, CheckboxListTile, and RadioListTile have not yet received unified settings from ListTileThemeData. However, I think this could be added as a follow-up to this PR.

StanleyCocos · 2025-03-28T11:41:35Z

Could you take some time to review this request? cc @TahaTesser

TahaTesser · 2025-03-28T19:50:32Z

Could you take some time to review this request? cc @TahaTesser

Unfortunately, I'm quite occupied for a few months. This PR will be reviewed soon by the team during triage.

dkwingsmt

LGTM. I like how the test cases are written!

dkwingsmt · 2025-04-07T04:44:02Z

packages/flutter/test/material/list_tile_test.dart

+      );
+    }
+
+    void testTowLine() {


Suggested change

void testTowLine() {

void testTwoLine() {

Shall we rename them to expectTwoLine and expectThreeLine? Fits English grammar better imo.

Your suggestion was great. Thank you—I’ve already made the changes.

StanleyCocos · 2025-04-08T06:48:18Z

Would you mind helping me request a second review? I really appreciate it! cc @dkwingsmt

dkwingsmt · 2025-04-08T07:08:37Z

Of course not! I forgot about it since I was a bit busy today.

justinmc

LGTM with nits 👍 . Thanks for the thorough tests.

justinmc · 2025-04-08T16:13:44Z

packages/flutter/lib/src/material/list_tile.dart

@@ -482,7 +482,7 @@ class ListTile extends StatelessWidget {
  ///
  /// When using a [Text] widget for [title] and [subtitle], you can enforce
  /// line limits using [Text.maxLines].
-  final bool isThreeLine;
+  final bool? isThreeLine;


Can you add a sentence to the docs about what happens if this is null?

justinmc · 2025-04-08T16:14:04Z

packages/flutter/lib/src/material/list_tile_theme.dart

@@ -139,6 +140,9 @@ class ListTileThemeData with Diagnosticable {
  /// or [ExpansionTile.controlAffinity] or [SwitchListTile.controlAffinity] or [RadioListTile.controlAffinity].
  final ListTileControlAffinity? controlAffinity;

+  /// If specified, overrides the default value of [ListTile.isThreeLine]


Period at the end here.

justinmc · 2025-04-08T16:15:13Z

packages/flutter/test/material/list_tile_test.dart

+      buildFrame(themeDataIsThreeLine: false, themeIsThreeLine: false, isThreeLine: true),
+    );
+    expectThreeLine();
+  });


Thanks for covering all the different combinations in the test 👍

StanleyCocos · 2025-04-09T03:36:37Z

Thank you all. I believe this PR is ready. If you have time, could you please help add a commit label? Much appreciated. @dkwingsmt @justinmc

…r#165481)

…hrough the theme. (#166826) This PR is a continuation of [165481](#165481) Related items also include: [SwitchListTile](#166820), [RadioListTile](#166964) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…gh the (#166964) This PR is a continuation of [165481](#165481) Related items also include: [SwitchListTile](#166820), [CheckboxListTile](#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

…ough the theme. (#166820) This PR is a continuation of [165481](#165481) Related items also include: [RadioListTile](#166964), [CheckboxListTile](#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…gh the (flutter#166964) This PR is a continuation of [165481](flutter#165481) Related items also include: [SwitchListTile](flutter#166820), [CheckboxListTile](flutter#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

…ough the theme. (flutter#166820) This PR is a continuation of [165481](flutter#165481) Related items also include: [RadioListTile](flutter#166964), [CheckboxListTile](flutter#166826) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…r#165481)

fix: flutter#165453 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…hrough the theme. (flutter#166826) This PR is a continuation of [165481](flutter#165481) Related items also include: [SwitchListTile](flutter#166820), [RadioListTile](flutter#166964) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…r#165481)

StanleyCocos added 2 commits March 19, 2025 15:06

add isThreeLine

cdf6492

++

1fce11d

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 19, 2025

StanleyCocos added 9 commits March 19, 2025 19:19

add test

708cce8

++

c491b37

++

9835a3c

Merge branch 'master' into fix/list_tile

788abb0

fix: test

5cd5a09

add test

1cdbc54

add test

419b7a7

fix: test

f818e3c

Merge branch 'master' into fix/list_tile

cd69629

StanleyCocos marked this pull request as ready for review March 21, 2025 03:12

Merge branch 'master' into fix/list_tile

d27f896

dkwingsmt self-requested a review April 3, 2025 00:31

dkwingsmt approved these changes Apr 7, 2025

View reviewed changes

StanleyCocos added 2 commits April 7, 2025 14:19

++

3901b15

Merge branch 'master' into fix/list_tile

7f7c5d9

justinmc approved these changes Apr 8, 2025

View reviewed changes

StanleyCocos added 3 commits April 9, 2025 09:13

++

ad8a48a

Merge branch 'master' into fix/list_tile

a18ed59

Merge branch 'master' into fix/list_tile

e70541f

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

bcb69ce

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

5a869de

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

bec546c

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

dfe30ff

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

e1fc6d2

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

39921bd

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

4d05e73

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

a143fd5

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

576cd09

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

5b8facf

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

3d3e21d

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

4ca48bd

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

fba4a12

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

2432145

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

cf5423d

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

e794bc5

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

8c162ac

…r#165481)

StanleyCocos deleted the fix/list_tile branch May 8, 2025 01:45

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

1ab101f

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

29dd833

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

aaee981

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

af0a9ae

…r#165481)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

9c4e49ea7 fix(ListTileTheme): isThreeLine is missing. (flutter/flutte…

c4573fb

…r#165481)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ListTileTheme): isThreeLine is missing. #165481

fix(ListTileTheme): isThreeLine is missing. #165481

Uh oh!

StanleyCocos commented Mar 19, 2025 •

edited

Loading

Uh oh!

StanleyCocos commented Mar 21, 2025

Uh oh!

StanleyCocos commented Mar 28, 2025

Uh oh!

TahaTesser commented Mar 28, 2025 •

edited

Loading

Uh oh!

dkwingsmt left a comment

Uh oh!

dkwingsmt Apr 7, 2025

Uh oh!

dkwingsmt Apr 7, 2025

Uh oh!

StanleyCocos Apr 7, 2025

Uh oh!

StanleyCocos commented Apr 8, 2025

Uh oh!

dkwingsmt commented Apr 8, 2025 •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

justinmc Apr 8, 2025

Uh oh!

justinmc Apr 8, 2025

Uh oh!

justinmc Apr 8, 2025

Uh oh!

StanleyCocos commented Apr 9, 2025

Uh oh!

Uh oh!

fix(ListTileTheme): isThreeLine is missing. #165481

fix(ListTileTheme): isThreeLine is missing. #165481

Uh oh!

Conversation

StanleyCocos commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

StanleyCocos commented Mar 21, 2025

Uh oh!

StanleyCocos commented Mar 28, 2025

Uh oh!

TahaTesser commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

StanleyCocos Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

StanleyCocos commented Apr 8, 2025

Uh oh!

dkwingsmt commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

StanleyCocos commented Apr 9, 2025

Uh oh!

Uh oh!

StanleyCocos commented Mar 19, 2025 •

edited

Loading

TahaTesser commented Mar 28, 2025 •

edited

Loading

dkwingsmt commented Apr 8, 2025 •

edited

Loading