-
Notifications
You must be signed in to change notification settings - Fork 29.2k
Feat: Animate fill for material app bar #163913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Thanks for the change. Although I do see how it's improving the fidelity, it probably shouldn't be implemented on Also we'll need some tests to guarantee it's not broken after the merge. |
a3352c9
to
b9253bb
Compare
@dkwingsmt Its ready to review again. |
|
||
expect(getAppBarAnimatedBackgroundColor(tester), defaultColor); | ||
await tester.pumpAndSettle(); | ||
expect(getAppBarAnimatedBackgroundColor(tester), scrolledColor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this test case verifies the feature. It only verifies the starting color and ending color, while you're trying to verify that there's a smooth animation in between. I recommend going without pumpAndSettle
but pump
ing a time instead, and it should result in a intermediate color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Let me do the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed changes for 2 intermediate color.
- At 50ms after animation start
- At 100ms after animation start
Animation duration is 200ms.
b1a60d1
to
5144d7a
Compare
The errors seem to be caused by comparing equality of the floating points. Try |
5144d7a
to
a646e41
Compare
Thanks, this worked very well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! This looks great to me. Just left one comment and then we are good to go:)
@@ -2339,6 +2341,39 @@ void main() { | |||
expect(tester.getSize(findAppBarMaterial()).height, kToolbarHeight); | |||
}); | |||
|
|||
testWidgets('backgroundColor animation', (WidgetTester tester) async { | |||
await tester.pumpWidget( | |||
buildAppBar(contentHeight: 1200.0, surfaceTintColor: Colors.transparent), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surfaceTintColor
has been deprecated in specs, even though we haven't cleaned it up here. So I think it would be better if we don't introduce more use case like this. Instead of changing surfaceTintColor
to transparent, I think assigning scrolledUnderElevation: 0
in appbar will also work for this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me push the change.
a646e41
to
d90c3ff
Compare
@@ -2244,11 +2244,15 @@ void main() { | |||
required double contentHeight, | |||
bool reverse = false, | |||
bool includeFlexibleSpace = false, | |||
Color? surfaceTintColor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Color? surfaceTintColor, |
}) { | ||
return MaterialApp( | ||
home: Scaffold( | ||
appBar: AppBar( | ||
elevation: 0, | ||
surfaceTintColor: surfaceTintColor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surfaceTintColor: surfaceTintColor, |
d90c3ff
to
6e290ab
Compare
I took a look at the failed Google testing yesterday, seems it breaks several tests and causes wrong background color for appbar. I'm still not sure the root cause. |
Just an update, I'm looking at the google failures today:) |
I'm still very confused what caused the Scuba failures:( Might need to ask for some help from @dkwingsmt to see if he has any insights. It seems some failures show that the background color of the app bar just disappear. I'm thinking if we can add an |
It seems that the failures are real. I'm taking a look. |
6e290ab
to
da75dbd
Compare
I have added |
Ah so quick! I talked with @dkwingsmt offline just now. Can we still keep the original fix? I think we found the cause, so I'll provide a fix in g3. |
d6c28c6
to
db087ac
Compare
No, issue. I have pushed the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution and quick response!
@@ -773,6 +774,9 @@ class AppBar extends StatefulWidget implements PreferredSizeWidget { | |||
/// {@endtemplate} | |||
final EdgeInsetsGeometry? actionsPadding; | |||
|
|||
/// Whether the color should be animated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// Whether the color should be animated. | |
/// Whether the background color should be animated when scroll starts and ends. |
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) flutter/flutter@cfb887c...b0f5c8c 2025-05-07 34465683+rkishan516@users.noreply.github.com Feat: Animate fill for material app bar (flutter/flutter#163913) 2025-05-07 engine-flutter-autoroll@skia.org Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483) 2025-05-07 15619084+vashworth@users.noreply.github.com Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452) 2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440) 2025-05-07 chris@bracken.jp macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415) 2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434) 2025-05-07 chris@bracken.jp iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390) 2025-05-06 jason-simmons@users.noreply.github.com Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411) 2025-05-06 markzipan@google.com Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421) 2025-05-06 jmccandless@google.com Ignore pointer on the outgoing route (flutter/flutter#168425) 2025-05-06 jacksongardner@google.com [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384) 2025-05-06 chinmaygarde@google.com [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401) 2025-05-06 sokolovskyi.konstantin@gmail.com Add height and width aspects to MediaQuery. (flutter/flutter#167829) 2025-05-06 engine-flutter-autoroll@skia.org Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392) 2025-05-06 matanlurey@users.noreply.github.com Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387) 2025-05-06 15619084+vashworth@users.noreply.github.com Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360) 2025-05-06 stanleycocoa@gmail.com feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820) 2025-05-06 kevmoo@users.noreply.github.com [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201) 2025-05-06 codefu@google.com Upload `android-arm64-release` treemap to known location (flutter/flutter#168349) 2025-05-06 stanleycocoa@gmail.com feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964) 2025-05-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347) 2025-05-05 36861262+QuncCccccc@users.noreply.github.com Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339) 2025-05-05 jessiewong401@gmail.com Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464) 2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346) 2025-05-05 chris@bracken.jp macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174) 2025-05-05 jason-simmons@users.noreply.github.com Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238) 2025-05-05 markzipan@google.com Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256) 2025-05-05 engine-flutter-autoroll@skia.org Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338) 2025-05-05 jason-simmons@users.noreply.github.com Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248) 2025-05-05 21270878+elliette@users.noreply.github.com [Widget Inspector] Add on-device button for changing default "tap" behavior (flutter/flutter#167677) 2025-05-05 markzipan@google.com Adding utf-8 encoding to hello world's html template (flutter/flutter#168162) 2025-05-05 1063596+reidbaker@users.noreply.github.com Update goldens.dart error to point to moved file (flutter/flutter#168319) 2025-05-05 jacksongardner@google.com Skwasm heavy (flutter/flutter#166619) 2025-05-05 jason-simmons@users.noreply.github.com Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317) 2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321) 2025-05-05 52936414+CoderNamedHendrick@users.noreply.github.com Cupertino sheet MediaQuery values (flutter/flutter#168041) 2025-05-05 34871572+gmackall@users.noreply.github.com Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278) 2025-05-05 flar@google.com [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276) ...
…er#9223) Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) flutter/flutter@cfb887c...b0f5c8c 2025-05-07 34465683+rkishan516@users.noreply.github.com Feat: Animate fill for material app bar (flutter/flutter#163913) 2025-05-07 engine-flutter-autoroll@skia.org Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483) 2025-05-07 15619084+vashworth@users.noreply.github.com Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452) 2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440) 2025-05-07 chris@bracken.jp macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415) 2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434) 2025-05-07 chris@bracken.jp iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390) 2025-05-06 jason-simmons@users.noreply.github.com Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411) 2025-05-06 markzipan@google.com Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421) 2025-05-06 jmccandless@google.com Ignore pointer on the outgoing route (flutter/flutter#168425) 2025-05-06 jacksongardner@google.com [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384) 2025-05-06 chinmaygarde@google.com [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401) 2025-05-06 sokolovskyi.konstantin@gmail.com Add height and width aspects to MediaQuery. (flutter/flutter#167829) 2025-05-06 engine-flutter-autoroll@skia.org Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392) 2025-05-06 matanlurey@users.noreply.github.com Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387) 2025-05-06 15619084+vashworth@users.noreply.github.com Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360) 2025-05-06 stanleycocoa@gmail.com feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820) 2025-05-06 kevmoo@users.noreply.github.com [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201) 2025-05-06 codefu@google.com Upload `android-arm64-release` treemap to known location (flutter/flutter#168349) 2025-05-06 stanleycocoa@gmail.com feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964) 2025-05-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347) 2025-05-05 36861262+QuncCccccc@users.noreply.github.com Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339) 2025-05-05 jessiewong401@gmail.com Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464) 2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346) 2025-05-05 chris@bracken.jp macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174) 2025-05-05 jason-simmons@users.noreply.github.com Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238) 2025-05-05 markzipan@google.com Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256) 2025-05-05 engine-flutter-autoroll@skia.org Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338) 2025-05-05 jason-simmons@users.noreply.github.com Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248) 2025-05-05 21270878+elliette@users.noreply.github.com [Widget Inspector] Add on-device button for changing default "tap" behavior (flutter/flutter#167677) 2025-05-05 markzipan@google.com Adding utf-8 encoding to hello world's html template (flutter/flutter#168162) 2025-05-05 1063596+reidbaker@users.noreply.github.com Update goldens.dart error to point to moved file (flutter/flutter#168319) 2025-05-05 jacksongardner@google.com Skwasm heavy (flutter/flutter#166619) 2025-05-05 jason-simmons@users.noreply.github.com Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317) 2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321) 2025-05-05 52936414+CoderNamedHendrick@users.noreply.github.com Cupertino sheet MediaQuery values (flutter/flutter#168041) 2025-05-05 34871572+gmackall@users.noreply.github.com Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278) 2025-05-05 flar@google.com [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276) ...
…er#9223) Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) flutter/flutter@cfb887c...b0f5c8c 2025-05-07 34465683+rkishan516@users.noreply.github.com Feat: Animate fill for material app bar (flutter/flutter#163913) 2025-05-07 engine-flutter-autoroll@skia.org Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483) 2025-05-07 15619084+vashworth@users.noreply.github.com Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452) 2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440) 2025-05-07 chris@bracken.jp macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415) 2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434) 2025-05-07 chris@bracken.jp iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390) 2025-05-06 jason-simmons@users.noreply.github.com Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411) 2025-05-06 markzipan@google.com Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421) 2025-05-06 jmccandless@google.com Ignore pointer on the outgoing route (flutter/flutter#168425) 2025-05-06 jacksongardner@google.com [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384) 2025-05-06 chinmaygarde@google.com [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401) 2025-05-06 sokolovskyi.konstantin@gmail.com Add height and width aspects to MediaQuery. (flutter/flutter#167829) 2025-05-06 engine-flutter-autoroll@skia.org Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392) 2025-05-06 matanlurey@users.noreply.github.com Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387) 2025-05-06 15619084+vashworth@users.noreply.github.com Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360) 2025-05-06 stanleycocoa@gmail.com feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820) 2025-05-06 kevmoo@users.noreply.github.com [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201) 2025-05-06 codefu@google.com Upload `android-arm64-release` treemap to known location (flutter/flutter#168349) 2025-05-06 stanleycocoa@gmail.com feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964) 2025-05-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347) 2025-05-05 36861262+QuncCccccc@users.noreply.github.com Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339) 2025-05-05 jessiewong401@gmail.com Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464) 2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346) 2025-05-05 chris@bracken.jp macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174) 2025-05-05 jason-simmons@users.noreply.github.com Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238) 2025-05-05 markzipan@google.com Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256) 2025-05-05 engine-flutter-autoroll@skia.org Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338) 2025-05-05 jason-simmons@users.noreply.github.com Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248) 2025-05-05 21270878+elliette@users.noreply.github.com [Widget Inspector] Add on-device button for changing default "tap" behavior (flutter/flutter#167677) 2025-05-05 markzipan@google.com Adding utf-8 encoding to hello world's html template (flutter/flutter#168162) 2025-05-05 1063596+reidbaker@users.noreply.github.com Update goldens.dart error to point to moved file (flutter/flutter#168319) 2025-05-05 jacksongardner@google.com Skwasm heavy (flutter/flutter#166619) 2025-05-05 jason-simmons@users.noreply.github.com Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317) 2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321) 2025-05-05 52936414+CoderNamedHendrick@users.noreply.github.com Cupertino sheet MediaQuery values (flutter/flutter#168041) 2025-05-05 34871572+gmackall@users.noreply.github.com Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278) 2025-05-05 flar@google.com [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276) ...
…er#9223) Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) flutter/flutter@cfb887c...b0f5c8c 2025-05-07 34465683+rkishan516@users.noreply.github.com Feat: Animate fill for material app bar (flutter/flutter#163913) 2025-05-07 engine-flutter-autoroll@skia.org Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483) 2025-05-07 15619084+vashworth@users.noreply.github.com Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452) 2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444) 2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440) 2025-05-07 chris@bracken.jp macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415) 2025-05-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434) 2025-05-07 chris@bracken.jp iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390) 2025-05-06 jason-simmons@users.noreply.github.com Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411) 2025-05-06 markzipan@google.com Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421) 2025-05-06 jmccandless@google.com Ignore pointer on the outgoing route (flutter/flutter#168425) 2025-05-06 jacksongardner@google.com [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384) 2025-05-06 chinmaygarde@google.com [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401) 2025-05-06 sokolovskyi.konstantin@gmail.com Add height and width aspects to MediaQuery. (flutter/flutter#167829) 2025-05-06 engine-flutter-autoroll@skia.org Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392) 2025-05-06 matanlurey@users.noreply.github.com Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387) 2025-05-06 15619084+vashworth@users.noreply.github.com Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363) 2025-05-06 engine-flutter-autoroll@skia.org Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360) 2025-05-06 stanleycocoa@gmail.com feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820) 2025-05-06 kevmoo@users.noreply.github.com [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201) 2025-05-06 codefu@google.com Upload `android-arm64-release` treemap to known location (flutter/flutter#168349) 2025-05-06 stanleycocoa@gmail.com feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964) 2025-05-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347) 2025-05-05 36861262+QuncCccccc@users.noreply.github.com Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339) 2025-05-05 jessiewong401@gmail.com Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464) 2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346) 2025-05-05 chris@bracken.jp macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174) 2025-05-05 jason-simmons@users.noreply.github.com Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238) 2025-05-05 markzipan@google.com Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256) 2025-05-05 engine-flutter-autoroll@skia.org Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338) 2025-05-05 jason-simmons@users.noreply.github.com Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248) 2025-05-05 21270878+elliette@users.noreply.github.com [Widget Inspector] Add on-device button for changing default "tap" behavior (flutter/flutter#167677) 2025-05-05 markzipan@google.com Adding utf-8 encoding to hello world's html template (flutter/flutter#168162) 2025-05-05 1063596+reidbaker@users.noreply.github.com Update goldens.dart error to point to moved file (flutter/flutter#168319) 2025-05-05 jacksongardner@google.com Skwasm heavy (flutter/flutter#166619) 2025-05-05 jason-simmons@users.noreply.github.com Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317) 2025-05-05 engine-flutter-autoroll@skia.org Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321) 2025-05-05 52936414+CoderNamedHendrick@users.noreply.github.com Cupertino sheet MediaQuery values (flutter/flutter#168041) 2025-05-05 34871572+gmackall@users.noreply.github.com Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278) 2025-05-05 flar@google.com [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276) ...
Feat: Animate fill for material app bar
fixes: #162988
Pre-launch Checklist
///
).