Skip to content

Conversation

rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Feb 22, 2025

Feat: Add yearShape property to DatePickerThemeData
fixes: #163340

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 22, 2025
@rkishan516 rkishan516 force-pushed the date-picker-year-shape branch from 511d91d to fd0d544 Compare February 22, 2025 04:15
@dkwingsmt dkwingsmt self-requested a review March 12, 2025 18:50
@rkishan516 rkishan516 force-pushed the date-picker-year-shape branch from de44e9b to 793d8eb Compare March 13, 2025 01:33
@rkishan516 rkishan516 requested a review from matanlurey as a code owner March 13, 2025 01:33
@@ -944,6 +975,9 @@ class _DatePickerDefaultsM2 extends DatePickerThemeData {
elevation: 24.0,
shape: const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(4.0))),
dayShape: const MaterialStatePropertyAll<OutlinedBorder>(CircleBorder()),
yearShape: const MaterialStatePropertyAll<OutlinedBorder>(
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(28.0))),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this probably changes the default shape. The default shape is always a pill shape, which has borderRadius equal to half the height. Using a fixed border radius here should result in a different shape if textScaleFactor is customized.

I think StadiumBorder should work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, previously borderRadius was equal to half the height. So, I will use StadiumBorder instead.

@@ -944,6 +975,9 @@ class _DatePickerDefaultsM2 extends DatePickerThemeData {
elevation: 24.0,
shape: const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(4.0))),
dayShape: const MaterialStatePropertyAll<OutlinedBorder>(CircleBorder()),
yearShape: const MaterialStatePropertyAll<OutlinedBorder>(
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(28.0))),
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if the comment above is true, can you add a test case to verify that the default year shape is kept with a different textScaleFactor (likely by verifying the drawRRect operation)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkwingsmt I have pushed the change. Since i have made it StadiumBorder. It's respecting border radius based on that. Also as you noted, I have written test for that.

@rkishan516 rkishan516 force-pushed the date-picker-year-shape branch 5 times, most recently from 551cd89 to 1fd5613 Compare March 18, 2025 10:10
@@ -67,7 +67,7 @@
"md.comp.date-picker.modal.year-selection.year.selected.label-text.color": "onPrimary",
"md.comp.date-picker.modal.year-selection.year.selected.pressed.state-layer.color": "onPrimary",
"md.comp.date-picker.modal.year-selection.year.state-layer.height": 36.0,
"md.comp.date-picker.modal.year-selection.year.state-layer.shape": "md.sys.shape.corner.full",
"md.comp.date-picker.modal.year-selection.year.state-layer.shape": "md.sys.shape.corner.extra-large",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not, removing now.

@dkwingsmt
Copy link
Contributor

Also analyzer error:

║ date_picker_theme.dart is not up-to-date with the token template file.
║ See: https://github.com/flutter/flutter/blob/main/dev/tools/gen_defaults to update the token template files.

@rkishan516 rkishan516 force-pushed the date-picker-year-shape branch 6 times, most recently from 7f31721 to 911ef06 Compare March 19, 2025 11:37
@rkishan516 rkishan516 requested a review from dkwingsmt March 19, 2025 12:46
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The Google tests have reported a failure, but it looks like it was a mistake. They seem to have passed when I look internally. I will set them to passing.

@dkwingsmt dkwingsmt added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Mar 28, 2025
Copy link
Contributor

auto-submit bot commented Mar 28, 2025

autosubmit label was removed for flutter/flutter/163909, because - The status or check suite Mac channels_integration_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux run_release_test_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux run_debug_test_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 10, 2025
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
…(#9041)

Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
Feat: Add yearShape property to DatePickerThemeData
fixes: flutter#163340 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by stuartmorgan@google.com

flutter/flutter@212064a...9bf18f0

2025-04-08 1063596+reidbaker@users.noreply.github.com bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 matanlurey@users.noreply.github.com Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 muhatashim@google.com add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 engine-flutter-autoroll@skia.org Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 103958012+ahmedrasar@users.noreply.github.com Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 43089218+chika3742@users.noreply.github.com Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166503)
2025-04-08 dkwingsmt@users.noreply.github.com Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 yjbanov@google.com [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 58529443+srujzs@users.noreply.github.com [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 jason-simmons@users.noreply.github.com Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 34465683+rkishan516@users.noreply.github.com Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 bkonyi@google.com [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 34871572+gmackall@users.noreply.github.com [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 bkonyi@google.com Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 jessy.yameogo@gmail.com [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 engine-flutter-autoroll@skia.org Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 34465683+rkishan516@users.noreply.github.com Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 34871572+gmackall@users.noreply.github.com Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 liama@google.com Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 engine-flutter-autoroll@skia.org Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
Feat: Add yearShape property to DatePickerThemeData
fixes: flutter#163340 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add yearShape property to DatePickerThemeData
3 participants