Skip to content

Marks Mac_arm64_ios imitation_game_swiftui to be unflaky #163114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Marks Mac_arm64_ios imitation_game_swiftui to be unflaky #163114

merged 1 commit into from
May 8, 2025

Conversation

fluttergithubbot
Copy link
Contributor

The test has been passing for 50 consecutive runs.
This test can be marked as unflaky.

@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Feb 12, 2025
@github-actions github-actions bot removed the c: tech-debt Technical debt, code quality, testing, etc. label Feb 12, 2025
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

auto-submit bot pushed a commit to flutter/cocoon that referenced this pull request Apr 11, 2025
@matanlurey
Flaky test bot: Add more debugging and a large regression test. (#4482)
36b11d9 
Further work towards debugging why flutter/flutter#166758 occurs in prod.

Locally, with a regression test, it does mark `Windows plugin_test` as non-flaky, but in prod:
```txt
> DEBUG 2025-04-09T09:20:07.673Z Skipping Linux analyzer_benchmark, could not find matching builder line
> DEBUG 2025-04-09T09:20:07.831Z Skipping Linux coverage, could not find matching builder line
> DEBUG 2025-04-09T09:20:07.833Z Skipping Linux_android_emu_unstable android_defines_test, an existing PR is open: flutter/flutter#165961
> DEBUG 2025-04-09T09:20:07.989Z Skipping Linux_pixel_7pro android_semantics_integration_test, could not find matching builder line
> DEBUG 2025-04-09T09:20:08.185Z Skipping Linux_mokey hybrid_android_views_integration_test, could not find matching builder line
> DEBUG 2025-04-09T09:20:08.407Z Skipping Linux_mokey new_gallery__crane_perf, could not find matching builder line
> DEBUG 2025-04-09T09:20:08.415Z Skipping Staging_build_linux analyze, ignore_flakiness specified
> DEBUG 2025-04-09T09:20:08.610Z Skipping Mac_mokey run_debug_test_android, could not find matching builder line
> DEBUG 2025-04-09T09:20:08.792Z Skipping Mac_mokey run_release_test, could not find matching builder line
> DEBUG 2025-04-09T09:20:08.793Z Skipping Mac_arm64_ios imitation_game_flutter, an existing PR is open: flutter/flutter#163113
> DEBUG 2025-04-09T09:20:08.793Z Skipping Mac_arm64_ios imitation_game_swiftui, an existing PR is open: flutter/flutter#163114
> DEBUG 2025-04-09T09:20:09.008Z Skipping Windows plugin_test, could not find matching builder line
> DEBUG 2025-04-09T09:20:09.219Z Skipping Windows_arm64 plugin_test_windows, could not find matching builder line
> DEBUG 2025-04-09T09:20:09.219Z Skipping Linux flutter_packaging, could not find matching builder line
> DEBUG 2025-04-09T09:20:09.221Z Skipping Windows flutter_packaging, could not find matching builder line
```

I am guessing it's some sort of state error? The extra debugging lines will help.
Piinks
Piinks approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this still does not appear to be flaking anymore. LGTM to take off bring up.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 7, 2025
Merged via the queue into flutter:master with commit e5b3fc3 May 8, 2025
153 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
e5b3fc3aa Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (f…
73e61ec 
…lutter/flutter#163114)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
e5b3fc3aa Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (f…
355e1f8 
…lutter/flutter#163114)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
e5b3fc3aa Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (f…
11afb25 
…lutter/flutter#163114)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 8, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
Roll Flutter from b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) (#9230)
b270eae 
flutter/flutter@b0f5c8c...02d8c1a

2025-05-08 chris@bracken.jp iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517)
2025-05-08 engine-flutter-autoroll@skia.org Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548)
2025-05-08 zhongliu88889@gmail.com Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526)
2025-05-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525)
2025-05-08 36861262+QuncCccccc@users.noreply.github.com Make MergeSemantics be able to merge customAction (flutter/flutter#168414)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514)
2025-05-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#168509)
2025-05-07 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114)
2025-05-07 20605958+mohamedamara@users.noreply.github.com Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505)
2025-05-07 kevmoo@users.noreply.github.com [web] drop more use of deprecated JS functions (flutter/flutter#166157)
2025-05-07 83038251+nailahsall0@users.noreply.github.com docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489)
2025-05-07 matanlurey@users.noreply.github.com Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433)
2025-05-07 sokolovskyi.konstantin@gmail.com Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479)
2025-05-07 robert.ancell@canonical.com Fix stencil buffer leak (flutter/flutter#168448)
2025-05-07 robert.ancell@canonical.com Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447)
2025-05-07 robert.ancell@canonical.com Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) (flutte…
1cc9399 
…r#9230)

flutter/flutter@b0f5c8c...02d8c1a

2025-05-08 chris@bracken.jp iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517)
2025-05-08 engine-flutter-autoroll@skia.org Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548)
2025-05-08 zhongliu88889@gmail.com Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526)
2025-05-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525)
2025-05-08 36861262+QuncCccccc@users.noreply.github.com Make MergeSemantics be able to merge customAction (flutter/flutter#168414)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514)
2025-05-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#168509)
2025-05-07 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114)
2025-05-07 20605958+mohamedamara@users.noreply.github.com Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505)
2025-05-07 kevmoo@users.noreply.github.com [web] drop more use of deprecated JS functions (flutter/flutter#166157)
2025-05-07 83038251+nailahsall0@users.noreply.github.com docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489)
2025-05-07 matanlurey@users.noreply.github.com Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433)
2025-05-07 sokolovskyi.konstantin@gmail.com Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479)
2025-05-07 robert.ancell@canonical.com Fix stencil buffer leak (flutter/flutter#168448)
2025-05-07 robert.ancell@canonical.com Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447)
2025-05-07 robert.ancell@canonical.com Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from b0f5c8ce03e2 to 02d8c1aceb75 (19 revisions) (flutte…
25ae343 
…r#9230)

flutter/flutter@b0f5c8c...02d8c1a

2025-05-08 chris@bracken.jp iOS,macOS: Unify iOS,macOS build configs (flutter/flutter#168517)
2025-05-08 engine-flutter-autoroll@skia.org Roll Packages from b2ce3b0 to ab44c26 (3 revisions) (flutter/flutter#168548)
2025-05-08 zhongliu88889@gmail.com Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class (flutter/flutter#168345)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) (flutter/flutter#168526)
2025-05-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... (flutter/flutter#168525)
2025-05-08 36861262+QuncCccccc@users.noreply.github.com Make MergeSemantics be able to merge customAction (flutter/flutter#168414)
2025-05-08 engine-flutter-autoroll@skia.org Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) (flutter/flutter#168514)
2025-05-08 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#168509)
2025-05-07 fluttergithubbot@gmail.com Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (flutter/flutter#163114)
2025-05-07 20605958+mohamedamara@users.noreply.github.com Add option to hide trailing icon in DropdownMenu (flutter/flutter#167782)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) (flutter/flutter#168505)
2025-05-07 kevmoo@users.noreply.github.com [web] drop more use of deprecated JS functions (flutter/flutter#166157)
2025-05-07 83038251+nailahsall0@users.noreply.github.com docs: Fixed broken links in WidgetStateProperty documentations (flutter/flutter#168191)
2025-05-07 engine-flutter-autoroll@skia.org Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) (flutter/flutter#168489)
2025-05-07 matanlurey@users.noreply.github.com Use `config: enable-swift-...: false`, remove `disable-swift-...: true`. (flutter/flutter#168433)
2025-05-07 sokolovskyi.konstantin@gmail.com Replace MediaQuery.sizeOf with heightOf and widthOf. (flutter/flutter#168479)
2025-05-07 robert.ancell@canonical.com Fix stencil buffer leak (flutter/flutter#168448)
2025-05-07 robert.ancell@canonical.com Fix framebuffer leak rendering to secondary views. (flutter/flutter#168447)
2025-05-07 robert.ancell@canonical.com Fix uninitalized fields in FlutterWindowMetricsEvent (flutter/flutter#168446)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
e5b3fc3aa Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (f…
147b68b 
…lutter/flutter#163114)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
e5b3fc3aa Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (f…
161b49d 
…lutter/flutter#163114)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
e5b3fc3aa Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (f…
7e7c5f7 
…lutter/flutter#163114)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
e5b3fc3aa Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (f…
2edbcc0 
…lutter/flutter#163114)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
e5b3fc3aa Marks Mac_arm64_ios imitation_game_swiftui to be unflaky (f…
7099e44 
…lutter/flutter#163114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu

Assignees
No one assigned
Labels
c: flake Tests that sometimes, but not always, incorrectly pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluttergithubbot @Piinks