Skip to content

Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 #144001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2024
Merged

Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 #144001

merged 2 commits into from
Feb 27, 2024

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Feb 23, 2024 •
edited
Loading

Reverts #143973

This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. c: tech-debt Technical debt, code quality, testing, etc. labels Feb 23, 2024
@badayumut
Copy link

When will flutter support the new Color Scheme tokens? Current color palette is different what material 3 has now on native. For example Google apps now has dimmed, more contrasting surface versus what we have.

HansMuller
HansMuller approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2024
@auto-submit auto-submit bot merged commit 871d592 into master Feb 27, 2024
@auto-submit auto-submit bot deleted the revert-143973-revert-138521-introduce_new_color_roles branch February 27, 2024 20:21
@Piinks
Copy link
Contributor

Piinks commented Feb 27, 2024

This is breaking the tree with some un-approved golden file images. I am going to revert this until we can take a look.

@Piinks
Copy link
Contributor

Piinks commented Feb 27, 2024

Reason for revert: Failing goldens at the tip of tree

@Piinks Piinks added the revert Autorevert PR (with "Reason for revert:" comment) label Feb 27, 2024
auto-submit bot pushed a commit that referenced this pull request Feb 27, 2024
Revert "Reland - Introduce tone-based surfaces and accent color add-o…
aa00e56 
…ns - Part 2 (#144001)"

This reverts commit 871d592.
@auto-submit auto-submit bot mentioned this pull request Feb 27, 2024
Merged
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Feb 27, 2024
auto-submit bot added a commit that referenced this pull request Feb 27, 2024
@auto-submit
Reverts "Reland - Introduce tone-based surfaces and accent color add-…
2eee0b5 
…ons - Part 2 (#144001)" (#144262)

Reverts #144001

Initiated by: Piinks

Reason for reverting: Failing goldens at the tip of tree

Original PR Author: QuncCccccc

Reviewed By: {HansMuller}

This change reverts the following previous change:
Original Description:
Reverts #143973

This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
@QuncCccccc
Copy link
Contributor Author

Oh I forget to update golden files! Thanks for helping revert this! Somehow the golden test alert doesn't show up.

@Piinks
Copy link
Contributor

Piinks commented Feb 27, 2024

I am guessing it is because it was a reland. Since Gold had already seen the images before, it may have not alerted on the PR because they were sitting over here: https://flutter-gold.skia.org/

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
871d592 Reland - Introduce tone-based surfaces and accent color add-o…
4d582f2 
…ns - Part 2 (flutter/flutter#144001)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
871d592 Reland - Introduce tone-based surfaces and accent color add-o…
9bccab9 
…ns - Part 2 (flutter/flutter#144001)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
871d592 Reland - Introduce tone-based surfaces and accent color add-o…
d6ed449 
…ns - Part 2 (flutter/flutter#144001)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
871d592 Reland - Introduce tone-based surfaces and accent color add-o…
af68d57 
…ns - Part 2 (flutter/flutter#144001)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 28, 2024
@engine-flutter-autoroll
Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) (#6222)
6d02f03 
Manual roll Flutter from c30f998 to d00bfe8 (32 revisions)

Manual roll requested by bmparr@google.com

flutter/flutter@c30f998...d00bfe8

2024-02-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340)
2024-02-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338)
2024-02-28 15619084+vashworth@users.noreply.github.com Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275)
2024-02-28 christopherfujino@gmail.com [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190)
2024-02-28 github@alexv525.com �� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293)
2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283)
2024-02-28 polinach@google.com Use const route for notAnnounced. (flutter/flutter#144050)
2024-02-28 tessertaha@gmail.com Add `tabs_utils.dart` class (flutter/flutter#143937)
2024-02-28 36861262+QuncCccccc@users.noreply.github.com Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080)
2024-02-27 richadlu001@gmail.com fix: unexpected chinese punctuation (flutter/flutter#143678)
2024-02-27 42216813+eliasyishak@users.noreply.github.com Clean up lint ignores (flutter/flutter#144229)
2024-02-27 jhy03261997@gmail.com Reland [a11y] Add isEnabled semantics flag to  text field  (flutter/flutter#143601)
2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990)
2024-02-27 chris@bracken.jp [iOS] Fix naming in platform_view example (flutter/flutter#144247)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253)
2024-02-27 kustermann@google.com [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130)
2024-02-27 36861262+QuncCccccc@users.noreply.github.com Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001)
2024-02-27 tjrogertj@gmail.com bind missing add icon in platform_view example (flutter/flutter#132028)
2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207)
2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Remove strut migration flag from `TextPainter` (flutter/flutter#144242)
2024-02-27 15619084+vashworth@users.noreply.github.com Remove force Xcode debug workflow (flutter/flutter#144185)
2024-02-27 54558023+keyonghan@users.noreply.github.com Mark two other firebase targets as bringup: true (flutter/flutter#144234)
2024-02-27 15619084+vashworth@users.noreply.github.com Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)
2024-02-27 jonahwilliams@google.com Re-enable Impeller goldens blocking.  (flutter/flutter#144210)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) (flutter#6222
ffa05c1 
)

Manual roll Flutter from c30f998 to d00bfe8 (32 revisions)

Manual roll requested by bmparr@google.com

flutter/flutter@c30f998...d00bfe8

2024-02-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (flutter/flutter#144340)
2024-02-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (flutter/flutter#144338)
2024-02-28 15619084+vashworth@users.noreply.github.com Reland "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144275)
2024-02-28 christopherfujino@gmail.com [flutter_tools] Catch rpc error in render frame with raster stats (flutter/flutter#144190)
2024-02-28 github@alexv525.com �� Guard Flutter Android app by disallow task affinity by default (flutter/flutter#144018)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (flutter/flutter#144316)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (flutter/flutter#144296)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (flutter/flutter#144293)
2024-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (#144207)" (flutter/flutter#144292)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (flutter/flutter#144290)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (flutter/flutter#144288)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (flutter/flutter#144285)
2024-02-28 zanderso@users.noreply.github.com Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (flutter/flutter#144283)
2024-02-28 polinach@google.com Use const route for notAnnounced. (flutter/flutter#144050)
2024-02-28 tessertaha@gmail.com Add `tabs_utils.dart` class (flutter/flutter#143937)
2024-02-28 36861262+QuncCccccc@users.noreply.github.com Remove `bottomAppBarColor` from `ThemeData` (flutter/flutter#144080)
2024-02-27 richadlu001@gmail.com fix: unexpected chinese punctuation (flutter/flutter#143678)
2024-02-27 42216813+eliasyishak@users.noreply.github.com Clean up lint ignores (flutter/flutter#144229)
2024-02-27 jhy03261997@gmail.com Reland [a11y] Add isEnabled semantics flag to  text field  (flutter/flutter#143601)
2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Remove deprecated `CupertinoContextMenu.previewBuilder` (flutter/flutter#143990)
2024-02-27 chris@bracken.jp [iOS] Fix naming in platform_view example (flutter/flutter#144247)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (flutter/flutter#144262)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (flutter/flutter#144253)
2024-02-27 kustermann@google.com [web] Make flutter web profile builds always keep wasm symbols (flutter/flutter#144130)
2024-02-27 36861262+QuncCccccc@users.noreply.github.com Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (flutter/flutter#144001)
2024-02-27 tjrogertj@gmail.com bind missing add icon in platform_view example (flutter/flutter#132028)
2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Cache `FocusNode.enclosingScope`, clean up `descendantsAreFocusable` (flutter/flutter#144207)
2024-02-27 31859944+LongCatIsLooong@users.noreply.github.com Remove strut migration flag from `TextPainter` (flutter/flutter#144242)
2024-02-27 15619084+vashworth@users.noreply.github.com Remove force Xcode debug workflow (flutter/flutter#144185)
2024-02-27 54558023+keyonghan@users.noreply.github.com Mark two other firebase targets as bringup: true (flutter/flutter#144234)
2024-02-27 15619084+vashworth@users.noreply.github.com Add FlutterMacOS.xcframework artifact (flutter/flutter#143244)
2024-02-27 jonahwilliams@google.com Re-enable Impeller goldens blocking.  (flutter/flutter#144210)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
871d592 Reland - Introduce tone-based surfaces and accent color add-o…
78cb758 
…ns - Part 2 (flutter/flutter#144001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl Awaiting requested review from guidezpl

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuncCccccc @badayumut @Piinks @HansMuller