ListTileTheme should be a part of ThemeData #31247
Description
Steps to Reproduce
- Create a new flutter app
- Add a list tile widget with a secondary icon
- Add all icon themes to the ThemeData, Notice secondary icon attributes do not change
- Wrap Widget with ListTileTheme and add icon attributes, Notice secondary icon attributes changed.
https://gist.github.com/ibrahim-mubarak/f6f777396372ac400e0a7f129e5b1186
Logs
Output of flutter run --verbose
https://gist.github.com/ibrahim-mubarak/573222b2988f0149df74bd9a8bca0bd5
Output of flutter analyze
Analyzing list_tile_theme...
No issues found! (ran in 1.4s)
Output of flutter doctor -v
[✓] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.4 18E226, locale en-IN)
• Flutter version 1.2.1 at /Users/ibrahim/development/flutter
• Framework revision 8661d8aecd (9 weeks ago), 2019-02-14 19:19:53 -0800
• Engine revision 3757390fa4
• Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/ibrahim/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = /Users/ibrahim/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
• All Android licenses accepted.
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.2, Build version 10E125
• ios-deploy 1.9.4
• CocoaPods version 1.6.1
[✓] Android Studio (version 3.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 34.0.1
• Dart plugin version 182.5215
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
[✓] Android Studio
• Android Studio at /Applications/Android Studio 3.5 Preview.app/Contents
• Flutter plugin version 34.0.4
• Dart plugin version 191.6183.87
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[✓] VS Code (version 1.33.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 2.25.1
[✓] Connected device (1 available)
• iPhone Xʀ • CB9F9632-F724-40C0-8C12-8FB04A58DD26 • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator)
• No issues found!
If we are using The Navigators onGenerateRoute Function we have to wrap all our page widgets with ListTileTheme or the MaterialApp itself with ListTileTheme, both in my opinion, feels hacky