-
Notifications
You must be signed in to change notification settings - Fork 29.2k
Description
One of the issues we've been fighting since the break is frequent flake in the video_player
integration tests. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8759433708003124641/+/u/Run_package_tests/drive_examples/stdout is an example run, where the failure is:
02:13 +6: /b/s/w/ir/x/w/packages/packages/video_player/video_player/example/integration_test/video_player_test.dart: asset videos stay paused when seeking after video completed
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: <false>
Actual: <true>
When the exception was thrown, this was the stack:
#4 main.<anonymous closure>.<anonymous closure> (file:///b/s/w/ir/x/w/packages/packages/video_player/video_player/example/integration_test/video_player_test.dart:136:9)
<asynchronous suspension>
#5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:183:15)
<asynchronous suspension>
#6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1017:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
This was caught by the test expectation on the following line:
file:///b/s/w/ir/x/w/packages/packages/video_player/video_player/example/integration_test/video_player_test.dart line 136
The test description was:
stay paused when seeking after video completed
════════════════════════════════════════════════════════════════════════════════════════════════════
02:13 +6 -1: /b/s/w/ir/x/w/packages/packages/video_player/video_player/example/integration_test/video_player_test.dart: asset videos stay paused when seeking after video completed [E]
Test failed. See exception logs above.
The test description was: stay paused when seeking after video completed
I know I've seen that one fail in other cases, but I believe there's at least one other that's flaking quite a bit. I believe we had some flake in this test before, but as with #141136 and #140987 it seems like this got dramatically worse recently on emulators for unknown reasons.
We'll want to collect more failure data from recent failures on the waterfall, but I wanted to capture this now since as we've handled some of the other issues it's becoming clearer how bad this one is. (E.g., flutter/packages#5847 to try to fix other flake flaked on this test.)
I don't have numbers yet, but I think this one will also need some kind of disabling if we can't fix it soon. I can probably try to investigate a bit tomorrow.
/cc @reidbaker