Skip to content

Fix runtime comparison in glowing and stretching overscroll indicators #113840

@Piinks

Description

@Piinks

Follow up to #113212

There are some inconsistencies in how we set and compare the type of scroll notification in the GlowingOverscrollIndicator and the StretchingOverscrollIndicator in each's respective _handleScrollNotification method.

There should be a case where this type check creates a bug, but we haven't identified it yet. Once we can, we can write a test to include with the patch. See more comments and context in #113212.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listf: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions