Skip to content

[flutter_tools] general.shard and commands.shard/hermetic are not hermetic #107607

@christopherfujino

Description

@christopherfujino

The flutter_tools test suite should pass on local development devices. However, running dart test in //flutter/packages/flutter_tools will generally lead to hundreds of failures. Especially the unit test in the general.shard and commands.shard/hermetic should be hermetic and not dependent on the environment that they are run in. These tests that pass on CI but fail locally are most likely leaking the environment state, and only coincidentally pass on CI because the environment state is correct. These tests should be updated to fake out the real environment so that the tests are reproducible locally (integration tests will always have dependencies on the system they run on).

This is an umbrella tracking issue for PRs that fix individual tests.

As part of this, we should also remove all instances of @Tags(<string>['no-shuffle']) from the test suite (see #85160)

edits by @andrewkolos:

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    Status

    Planned Q3

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions