-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.f: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flightA fix is in flight
Description
The scrollbar painter has a bit of code rot.
While working on #13253, I found it hard to follow the painter logic and found several little bugs. This really needs a clean up to make it easier to work with. Some of the bugs I found have to do with padding and margins, these should likely be wrapped in consistent getters to use across the all of the painter methods.
Found bugs:
- Scrollbar margins are handled inconsistently #106918
- RawScrollbar does not apply track or border color #106917
- Scrollbar track offset does not account for padding #106834
Fix is in #107179
rydmike and xu-baolin
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.c: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.f: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flightA fix is in flight