This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add back FlutterViewTest.java #55048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If everything passes then I am going to assume the test file was not run and will want proof it did run before landing this pr. |
5 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2024
zanderso
reviewed
Sep 11, 2024
| @@ -0,0 +1,946 @@ | |||
| package io.flutter.embedding.android; | |||
There was a problem hiding this comment.
DBC
This file needs the engine copyright header.
There was a problem hiding this comment.
hey @zanderso none of the tests in this folder have a copyright notice.
https://github.com/flutter/engine/tree/8ccdbda31a991481567702f0050702ca6777d044/shell/platform/android/test/io/flutter/embedding/android
Is there a linter that is supposed to check for this in java files that needs to be modified?
In the meantime I have filed flutter/flutter#155118
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 11, 2024
…155031) flutter/engine@4eb729b...ade8ef2 2024-09-11 skia-flutter-autoroll@skia.org Roll Skia from 44b4a40178cc to fb0b2eb61b65 (1 revision) (flutter/engine#55104) 2024-09-11 reidbaker@google.com Add back FlutterViewTest.java (flutter/engine#55048) 2024-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8XJTJm4D4Go1dBaTi... to fKNT8lbGh8JzxjE6m... (flutter/engine#55103) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 8XJTJm4D4Go1 to fKNT8lbGh8Jz If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
Add back FlutterViewTest.java from aa1278e (last commit before it was deleted in flutter#44047) Fixes flutter/flutter/issues/154746
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back FlutterViewTest.java from aa1278e (last commit before it was deleted in #44047)
Fixes flutter/flutter/issues/154746
Pre-launch Checklist
///).