This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Remove physical geometry" #47862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ff13610.
fluttergithubbot
approved these changes
Nov 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 9, 2023
…sions) (#138154) Manual roll requested by zra@google.com flutter/engine@8b490a9...35cad36 2023-11-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove physical geometry" (flutter/engine#47862) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 7d0768083298 to df263765ebc8 (2 revisions) (flutter/engine#47860) 2023-11-09 chillers@google.com Reland "Remove Fuchsia Mac SDK from DEPS" (flutter/engine#47823) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 8f8c9a144797 to 7d0768083298 (1 revision) (flutter/engine#47858) 2023-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 6f36eb00cacf to 6bd98dc2dffd (1 revision) (flutter/engine#47857) 2023-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 14933042494d to 6f36eb00cacf (4 revisions) (flutter/engine#47855) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from b055626ce8c2 to 8f8c9a144797 (1 revision) (flutter/engine#47854) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from b6ce84dc3e53 to b055626ce8c2 (1 revision) (flutter/engine#47850) 2023-11-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sD8HRA4JmXczujkqO... to 0pD5ceqf-e9y9NTNn... (flutter/engine#47847) 2023-11-09 goderbauer@google.com Remove physical geometry (flutter/engine#47825) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from f3e4fd80eeeb to b6ce84dc3e53 (1 revision) (flutter/engine#47843) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from d9ec01cf15ff to f3e4fd80eeeb (3 revisions) (flutter/engine#47838) 2023-11-09 737941+loic-sharma@users.noreply.github.com [Windows] Remove global state in keyboard tests (flutter/engine#47829) 2023-11-08 mdebbar@google.com [web] Non-singleton implementation of ui.FlutterView (flutter/engine#47806) 2023-11-08 gspencergoog@users.noreply.github.com Move window state update to window realize callback (flutter/engine#47713) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from sD8HRA4JmXcz to 0pD5ceqf-e9y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@zanderso When you revert a change can you please, pretty please provide a reason for the revert. Like link to a failing test - or anything really. The engine dashboard is green on this change, so I have no idea why this was reverted. |
|
@goderbauer Sorry about that. I tagged you in the Engine Sheriff chat, but forgot to copy in the info here. The Engine -> Framework roll started to fail here #47825 in the docs test: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20docs_test/38784/overview |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #47825
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
Looks like this was proactively added in #20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.
Related framework PR: flutter/flutter#138103 (Checks will fail until that PR is submitted).