This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Add non-rendering operation culling to DisplayListBuilder" (#41463) #43831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#41463) This reverts commit 886a14e.
chinmaygarde
approved these changes
Jul 19, 2023
|
This version of the PR is nearly identical to the previous version except that I had to merge the changes in |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 20, 2023
…130953) flutter/engine@7671e2f...eff70f7 2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 936824d49aa7 to 677bbf64d4d7 (1 revision) (flutter/engine#43833) 2023-07-19 flar@google.com Reland "Add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#43831) 2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from bf75ae2f6eec to 8413c82dea43 (1 revision) (flutter/engine#43832) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
…lutter#41463) (flutter#43831) Fixes: flutter/flutter#129862 This reverts commit 886a14e. The framework test that was blocking the previous reland has been [fixed](flutter/flutter#130751) to not rely on non-visible (cullable) operations.
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130953) flutter/engine@7671e2f...eff70f7 2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 936824d49aa7 to 677bbf64d4d7 (1 revision) (flutter/engine#43833) 2023-07-19 flar@google.com Reland "Add non-rendering operation culling to DisplayListBuilder" (flutter#41463) (flutter/engine#43831) 2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from bf75ae2f6eec to 8413c82dea43 (1 revision) (flutter/engine#43832) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flutter/flutter#129862
This reverts commit 886a14e.
The framework test that was blocking the previous reland has been fixed to not rely on non-visible (cullable) operations.