This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adds bugprone-unchecked-optional-access to .clang-tidy #42281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d5ceca to
985903c
Compare
|
This is going to be so useful. We've run into this a few times in the past. cc @bdero |
|
There are more violations that I was expecting so I'll set us up to enable this incrementally. |
2 tasks
|
Roger. It might be a good idea to just enable this in Impeller first. Since all Impeller components have their own GN template, you can add this flag just for Impeller here. |
Yup, this is by far the most common way I push crashers. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP