Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

bdero
Copy link
Member

@bdero bdero commented May 23, 2023

Resolves flutter/flutter#122854.

One of those quality of life things I keep putting off...

@bdero bdero self-assigned this May 23, 2023
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdero bdero merged commit c284cd1 into flutter:main May 23, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 23, 2023
…127372)

flutter/engine@8d6602b...c284cd1

2023-05-23 bdero@google.com [Impeller] Place Entity Geometry classes in separate TUs (flutter/engine#42236)
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from fc369d15070f to 1c3d1e200d72 (1 revision) (flutter/engine#42235)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#127372)

flutter/engine@8d6602b...c284cd1

2023-05-23 bdero@google.com [Impeller] Place Entity Geometry classes in separate TUs (flutter/engine#42236)
2023-05-23 skia-flutter-autoroll@skia.org Roll Skia from fc369d15070f to 1c3d1e200d72 (1 revision) (flutter/engine#42235)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Impeller] Separate Impeller::Geometry classes into different TUs
2 participants