This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Cleanup Vector3 #42096
Merged
[web] Cleanup Vector3 #42096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
yjbanov
approved these changes
May 19, 2023
| final Float32List _v3storage; | ||
| const Vector3 kUnitX = (x: 1.0, y: 0.0, z: 0.0); | ||
| const Vector3 kUnitY = (x: 0.0, y: 1.0, z: 0.0); | ||
| const Vector3 kUnitZ = (x: 0.0, y: 0.0, z: 1.0); |
There was a problem hiding this comment.
Nice! This actually guarantees immutability, unlike the previous method of leaving comments with warnings.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 19, 2023
…127196) flutter/engine@e9178e1...2e6b1e6 2023-05-19 mdebbar@google.com [web] Cleanup Vector3 (flutter/engine#42096) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127196) flutter/engine@e9178e1...2e6b1e6 2023-05-19 mdebbar@google.com [web] Cleanup Vector3 (flutter/engine#42096) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have limited use of
Vector3in the engine, so I converted it into a record and removed almost all of its methods.Converting it to a record also means it's not mutable anymore, which is a positive in my book. That required a few minor changes in
Matrix4but nothing major.