This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix bounds when painting style is stroke width for image shaders #42052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Need to figure out what's changing in the goldens... |
bdero
approved these changes
May 15, 2023
I updated the goldens to draw both a stroke and a fill over the same area and make sure they match. I'm confused though about why some of them are changing. I'm going to be out today but will try to look tomorrow. |
|
Ok, verified locally the golden updates are because I'm not placing the stroke exactly on top of the fill in some cases. Rather than try to figure that out I'm going to approve them. This would still catch regressions. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 17, 2023
…127043) flutter/engine@47fd496...0ae3719 2023-05-17 dnfield@google.com Report displays for macOS (flutter/engine#41998) 2023-05-17 dnfield@google.com Fix bounds when painting style is stroke width for image shaders (flutter/engine#42052) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
May 18, 2023
…tter#42052) Fixes flutter/flutter#126739 When we're sampling from the texture, we need to sample from its origin regardless of how much offset the stroke width gives to the path.
CaseyHillers
pushed a commit
that referenced
this pull request
May 18, 2023
…age shaders (#42052) (#42129) Fixes flutter/flutter#126739 When we're sampling from the texture, we need to sample from its origin regardless of how much offset the stroke width gives to the path.
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127043) flutter/engine@47fd496...0ae3719 2023-05-17 dnfield@google.com Report displays for macOS (flutter/engine#41998) 2023-05-17 dnfield@google.com Fix bounds when painting style is stroke width for image shaders (flutter/engine#42052) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#126739
When we're sampling from the texture, we need to sample from its origin regardless of how much offset the stroke width gives to the path.