Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

CP: Use the arm64 dsymutil on Mac M1 machines (#42533) #42583

Merged
merged 2 commits into from
Jun 6, 2023
Merged

CP: Use the arm64 dsymutil on Mac M1 machines (#42533) #42583

merged 2 commits into from
Jun 6, 2023

Conversation

godofredoc
Copy link
Contributor

CP: 51928f2

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use the arm64 dsymutil on Mac M1 machines (#42533)
57ae338 
Use the right binary architectures on scripts running dsymutil.

This is to fix the problem of bad architecture binary for builds running on dart internal: flutter/flutter#128098

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@godofredoc godofredoc mentioned this pull request Jun 5, 2023
Closed
Jasguerrero
Jasguerrero approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 5, 2023
@auto-submit auto-submit bot merged commit efce4e1 into flutter:flutter-3.11-candidate.0 Jun 6, 2023
@godofredoc godofredoc deleted the flutter-3.11-candidate.0 branch June 6, 2023 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

2 more reviewers

@Jasguerrero Jasguerrero Jasguerrero approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@godofredoc @Jasguerrero @fluttergithubbot