Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

goderbauer
Copy link
Member

Follow-up to #42493.

The framework has been migrated to the new onSemanticsActionEvent callback.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jun 5, 2023
@goderbauer goderbauer marked this pull request as ready for review June 5, 2023 22:59
@goderbauer goderbauer requested a review from loic-sharma June 5, 2023 22:59
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was fast. LGTM!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 5, 2023
@auto-submit auto-submit bot merged commit 3b771ec into flutter:main Jun 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 6, 2023
…128301)

flutter/engine@2b353ae...aaa7574

2023-06-06 skia-flutter-autoroll@skia.org Roll Skia from 7db361be474b to e8a71c76b88f (4 revisions) (flutter/engine#42582)
2023-06-05 goderbauer@google.com Remove onSemanticsAction (flutter/engine#42579)
2023-06-05 godofredoc@google.com Use the arm64 dsymutil on Mac M1 machines (flutter/engine#42533)
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a226cfbd6cc7 to 7db361be474b (14 revisions) (flutter/engine#42578)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@goderbauer goderbauer deleted the removeOnSemanticsAction branch June 6, 2023 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants