This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use the arm64 dsymutil on Mac M1 machines #42533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Jun 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
CP: 51928f2 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2023
…128301) flutter/engine@2b353ae...aaa7574 2023-06-06 skia-flutter-autoroll@skia.org Roll Skia from 7db361be474b to e8a71c76b88f (4 revisions) (flutter/engine#42582) 2023-06-05 goderbauer@google.com Remove onSemanticsAction (flutter/engine#42579) 2023-06-05 godofredoc@google.com Use the arm64 dsymutil on Mac M1 machines (flutter/engine#42533) 2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a226cfbd6cc7 to 7db361be474b (14 revisions) (flutter/engine#42578) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
XilaiZhang
pushed a commit
to XilaiZhang/engine
that referenced
this pull request
Jun 20, 2023
Use the right binary architectures on scripts running dsymutil. This is to fix the problem of bad architecture binary for builds running on dart internal: flutter/flutter#128098 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
XilaiZhang
added a commit
that referenced
this pull request
Jun 20, 2023
Cherry pick into beta branch [example build failures on beta](https://luci-milo.appspot.com/ui/p/dart-internal/builders/flutter/Mac%20engine_release_builder/232/overview) Use the right binary architectures on scripts running dsymutil. This is to fix the problem of bad architecture binary for builds running on dart internal: flutter/flutter#128098 Co-authored-by: godofredoc <godofredoc@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the right binary architectures on scripts running dsymutil.
This is to fix the problem of bad architecture binary for builds running on dart internal: flutter/flutter#128098
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.