This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Generate a unique temporary directory name in the iOS scenario test script #42520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cript This ensures that a retry of this script on CI will not collide with the output directory of a previous run.
godofredoc
approved these changes
Jun 2, 2023
zanderso
reviewed
Jun 2, 2023
There was a problem hiding this comment.
lgtm
Is there any analogous change to make in https://github.com/flutter/engine/blob/main/testing/scenario_app/run_android_tests.sh ?
|
AFAICT there isn't any use of temporary paths in the Android scenario test script |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 2, 2023
…128149) flutter/engine@f3f6a02...8769e9c 2023-06-02 godofredoc@google.com Use json for json blocks in docs. (flutter/engine#42521) 2023-06-02 mdebbar@google.com [web] New platform view API to get view by ID (flutter/engine#41784) 2023-06-02 jason-simmons@users.noreply.github.com Generate a unique temporary directory name in the iOS scenario test script (flutter/engine#42520) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that a retry of this script on CI will not collide with the output directory of a previous run.