Roll dart, zlib, emscripten, tweak license script for rolled zlib #41299
Conversation
Changes since last dart roll ``` 2fcf9754032 Version 3.1.0-14.0.dev 393b1016292 Version 3.1.0-13.0.dev 39fc15a0b4c (origin/lkgr) [analysis_server] Add missing declaration semantic token modifier on classes/constructors 609db33dc7a Issue 51985. Quick fix to add missing pattern case to switch expression/pattern. 8fa08ae80b6 Add 'Convert to if-case statement' quick assist. 17d92f90d0b offer wildcard suggestions for destructured record fields 3149f813bbf [dartdev] Update --enable-analytics to re-enable unified analytics eee509140dd Add dependency overrides for pkg/analyzer 3069c4f3e2b [analysis_server] Add missing "constructor" semantic token modifiers on constructor declarations 9834f87c542 [dart2js] Fix noSuchMethod override handling. 639a6f06ef9 Simplify several non-terminals to use regex-like grammar operators f88e3bd77c5 Issue 51903. Test fixes for ParserErrorCode.VAR_AND_TYPE f4d42303ad2 [analysis_server] Handle completion in whitespace after string values 70762f0de0e [ANTLR] Transform recursive definition of onParts to use iteration ... 453647022f6 [analysis_server] Don't fail on invalid/complex setters in LSP code completion a565638b910 Issue 51689. Report when 'super' is used as a standalone expression, not as a receiver of an invocation. b78d89ce0c7 Fix DynamicTypeImpl to InterfaceTypeImpl cast exception in AddTypeAnnotation, when ambiguous SetOrMapLiteral. bd9c7a46e2b Roll zlib to 14dd4c4455602c9b71a1a89b5cafd1f4030d2e3f 18b5ecdfc99 [vm] Cleanup dead code around TypeArgumentClassFinder 9d4d48949c0 Add a top-level variable strict-inference test case 8df1b888771 [VM/Service] Create JSONBase64String class b4aa83b0b7f [VM/Service] Rename JSONStream::AppendSerializedObject to JSONStream::AppendBytes 4cd9c9c6666 Reland "[VM] Begin supporting Perfetto file recorder" fa3a72fa7e5 [cfe/ffi] Error on compound constructors ```
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@Hixie fyi - rolling of the zlib requires some tweaking to the license script: .3 is an exetnsion of man-page doc file plus some other minor tweks. |
tools/licenses/lib/filesystem.dart
Outdated
| @@ -257,6 +257,7 @@ FileType identifyFile(String name, Reader reader) { | |||
| case '.diff': | |||
| // Don't try to read the copyright out of patch files, since there'll be fragments. | |||
| return FileType.binary; | |||
| case '.3': | |||
There was a problem hiding this comment.
i think we do .1 in the paths.dart file, fwiw. might be worth making the two consistent with each other.
There was a problem hiding this comment.
skipping entirely (i.e. doing it in paths.dart) may be more correct if we don't ship the man file (which i assume we don't).
There was a problem hiding this comment.
Ah, interesting. Thanks, done.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…125094) flutter/engine@099ed6c...8b7cdb0 2023-04-19 aam@google.com Roll dart, zlib, emscripten, tweak license script for rolled zlib (flutter/engine#41299) 2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 84630c3c18b2 to 5a718d9e9c06 (3 revisions) (flutter/engine#41318) 2023-04-19 bdero@google.com [Impeller] Provide an opaque interface for color sources in Aiks (flutter/engine#41315) 2023-04-18 yjbanov@google.com [web:canvaskit] remove unnecessary instrumentation from picture (flutter/engine#41313) 2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 476ee3fd54cc to 84630c3c18b2 (5 revisions) (flutter/engine#41316) 2023-04-18 godofredoc@google.com Double zip FlutterMacOS.framework.zip. (flutter/engine#41306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changes since last dart roll