Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use gclient_variables consistently. #41162

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Use gclient_variables consistently. #41162

merged 4 commits into from
Apr 14, 2023

Conversation

godofredoc
Copy link
Contributor

Removes all the variants of gclient variables that were giving the illusion the variable was being used.

It also formats some files to keep the style consistent.

Bug: flutter/flutter#124772

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc requested a review from zanderso April 13, 2023 17:07
zanderso
zanderso reviewed Apr 13, 2023
View reviewed changes
zanderso
zanderso reviewed Apr 13, 2023
View reviewed changes
@godofredoc
Use gclient_variables consistently.
bacf0c7 
Removes all the variants of gclient variables that were giving the
illusion the variable was being used.

It also formats some files to keep the style consistent.

Bug: flutter/flutter#124772
@godofredoc
Revert back linux_arm_host_engine.
f08d1c4
@godofredoc
Update remaining uses of gclient_custom_variables.}
34fe808
@godofredoc
Android builds do need to download android deps.
439686e
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2023
@auto-submit auto-submit bot merged commit 51259a5 into flutter:main Apr 14, 2023
@godofredoc godofredoc deleted the fix_gclient branch April 14, 2023 05:03
@godofredoc godofredoc mentioned this pull request Apr 14, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2023
@engine-flutter-autoroll
51259a565 Use gclient_variables consistently. (flutter/engine#41162)
a23b3cc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2023
@engine-flutter-autoroll
51259a565 Use gclient_variables consistently. (flutter/engine#41162)
26d34c6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @zanderso