This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix the cmake example build. #41148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9e2f2a to
a716662
Compare
zanderso
commented
Apr 13, 2023
.ci.yaml
Outdated
| @@ -445,17 +445,16 @@ targets: | |||
| ] | |||
|
|
|||
| - name: Mac impeller-cmake-example | |||
| bringup: true | |||
| #bringup: true | |||
There was a problem hiding this comment.
I will uncomment this before landing. It's commented out to force it to run in the presubmit checks.
zanderso
commented
Apr 13, 2023
| $flutter/osx_sdk : >- | ||
| { "sdk_version": "14a5294e" } | ||
| dependencies: >- | ||
| [ | ||
| {"dependency": "cmake", "version": "build_id:8784715802296535313"}, |
There was a problem hiding this comment.
Pulling this in via the DEPS file instead since it's just a CIPD package.
chinmaygarde
approved these changes
Apr 13, 2023
a716662 to
d5466aa
Compare
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
[Impeller] Fix the cmake example build.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fit in better with the
engine_v2context, this PR shifts thecmakestep for theimpeller-cmake-exampleto run within theflutter/tools/gnscript. That way, the recipe will ensure thatGOMA_DIRis defined, goma is running, etc.. Since we usecmaketo generate a ninja build forimpeller-cmake-example, the engine_v2ninjastep can build it, and that feature of the python script is no longer needed.Successful run is here https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20impeller-cmake-example/12/overview