This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[ANGLE] Re-enable ANGLE's "force context check" build flag #37055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Oct 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 31, 2022
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…7055) In [angle@54dfb62](google/angle@54dfb62), ANGLE made the "force context check" flag off by default [to improve performance](https://chromium-review.googlesource.com/c/angle/angle/+/2809855). Disabling this flag uncovered several bugs in ANGLE's D3D11 renderer that can cause [Flutter 3.3.0+ to crash](flutter/flutter#110311). This change re-enables the "force context check" flag, bringing Flutter back to the last known good state used by Flutter 3.0.5 and earlier. Fixes flutter/flutter#110311
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In angle@54dfb62, ANGLE made the "force context check" flag off by default to improve performance. Disabling this flag uncovered several bugs in ANGLE's D3D11 renderer that can cause Flutter 3.3.0+ to crash. This change re-enables the "force context check" flag, bringing Flutter back to the last known good state used by Flutter 3.0.5 and earlier.
Fixes flutter/flutter#110311
What is the "force context check" flag?
Per the ANGLE team:
Flutter does not use ANGLE from multiple threads, so ideally Flutter would disable this flag.
Why don't we fix the bugs uncovered by disabling this ANGLE flag?
This is the ideal long-term solution. Tracked by flutter/flutter#114107.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.