Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Zip the dsym artifacts. #35075

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Zip the dsym artifacts. #35075

merged 2 commits into from
Aug 2, 2022

Conversation

godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Aug 2, 2022 •
edited
Loading

This is to move the zipping logic from recipes back to the engine.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc requested review from zanderso and jmagman August 2, 2022 17:10
@godofredoc godofredoc mentioned this pull request Aug 2, 2022
Merged
8 tasks
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2022
@auto-submit auto-submit bot merged commit 2b31732 into flutter:main Aug 2, 2022
@jmagman
Copy link
Member

jmagman commented Aug 2, 2022

This PR LGTM. As an aside, it's silly we zip these before the artifact it's in gets zipped, then the tool has to unzip twice. I fixed this for iOS but haven't done macOS.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2022
@engine-flutter-autoroll
2b31732 Zip the dsym artifacts. (flutter/engine#35075)
f3bf1c1
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Aug 5, 2022
@godofredoc @betrevisan
Zip the dsym artifacts. (flutter#35075)
291b4cb
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
@godofredoc @emilyabest
Zip the dsym artifacts. (flutter#35075)
009f5ce
@godofredoc godofredoc deleted the zip_file branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman Awaiting requested review from jmagman

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@godofredoc @jmagman @zanderso