Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add support relative path support to create_macos_framework. #35011

Merged
merged 12 commits into from
Aug 2, 2022
Merged

Add support relative path support to create_macos_framework. #35011

merged 12 commits into from
Aug 2, 2022

Conversation

godofredoc
Copy link
Contributor

This is required for generic build configurations where full paths are
not available.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2022
@auto-submit auto-submit bot merged commit 1c3b1b3 into flutter:main Aug 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 2, 2022
@engine-flutter-autoroll
1c3b1b3 Add support relative path support to create_macos_framework. (f…
75250b7 
…lutter/engine#35011)
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Aug 5, 2022
@godofredoc @betrevisan
Add support relative path support to create_macos_framework. (flutter…
75ca123 
…#35011)
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Aug 12, 2022
@godofredoc @emilyabest
Add support relative path support to create_macos_framework. (flutter…
815b873 
…#35011)
@godofredoc godofredoc deleted the update_generate_mac_os branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @chinmaygarde