This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Gn target to generate gen_snapshot for windows. #35986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new target to archive gen_snapshot for windows platforms. A new target is required because the naming convention is completely different from the one used for linux or mac. Bug: flutter/flutter#81855
8 tasks
| @@ -290,3 +291,16 @@ compile_platform("strong_platform") { | |||
| group("kernel_platform_files") { | |||
| public_deps = [ ":strong_platform" ] | |||
| } | |||
|
|
|||
| if (is_win) { | |||
| zip_bundle("archive_win_gen_snapshot") { | |||
There was a problem hiding this comment.
Who is the caller of this target definition? Is this patch complete?
There was a problem hiding this comment.
This was for experimenting with building the windows archives but we are currently blocked on arm support.
|
Closing this as being currently blocked on other work. Please re-open once progress can be made. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new target to archive gen_snapshot for windows platforms. A new target is required because the naming convention is completely different from the one used for linux or mac.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.